feat(Core/Time): Implement saparated manager for game time - #8630
Merged
Merged
Conversation
github-actions
Bot
added
CORE
Kitzunu
reviewed
Oct 20, 2021
Winfidonarleyan
marked this pull request as ready for review
October 26, 2021 07:25
7 of 9 tasks
Winfidonarleyan
marked this pull request as draft
October 28, 2021 12:51
Kitzunu
approved these changes
Dec 6, 2021
Kitzunu
left a comment
Kitzunu
left a comment
Member
There was a problem hiding this comment.
looks good as far as I can tell
Winfidonarleyan
force-pushed
the
game-time
branch
from
December 27, 2021 08:00
5c656f4 to
2e9a33c
Compare
Winfidonarleyan
marked this pull request as draft
January 16, 2022 23:25
Member
Author
|
Wait - #10207 |
Winfidonarleyan
removed
the
run-build
Winfidonarleyan
marked this pull request as ready for review
January 23, 2022 09:12
Nyeriah
approved these changes
Jan 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
GameTimenamespace andUpdateTimeclass and moved their code out ofWorldclassstd::chronolib https://en.cppreference.com/w/cpp/chrono/time_point/time_since_epochIssues Addressed:
SOURCE:
Tests Performed:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.