Skip to content

feat: add git to topo health checks #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
federicobozzini wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −0
Draft

feat: add git to topo health checks #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcf5178
feat: add git to topo health checks
federicobozzini Sep 2, 2026
47611c6
Severity converted to warning
federicobozzini Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ Not sure what these terms mean? The [glossary](docs/introduction/glossary.md) de
**Host machine** (where you run `topo`):

- [Docker](#install-a-container-engine)
- [Git](https://git-scm.com/downloads)
- OpenSSH Client

**Target machine** (the remote Arm system):
Expand Down
1 change: 1 addition & 0 deletions e2e/health_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ func TestHealthCheck(t *testing.T) {
require.NoError(t, err)

assert.Contains(t, out, " ✓ OpenSSH (ssh)")
assert.Contains(t, out, " ✓ Git (git)")
assert.Contains(t, out, " ✓ Container Engine (docker)")
})

Expand Down
5 changes: 5 additions & 0 deletions e2e/testdata/TestHealthCheckJson.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
"status": "ok",
"value": "ssh"
},
{
"name": "Git",
"status": "ok",
"value": "git"
},
{
"name": "Container Engine",
"status": "ok",
Expand Down
10 changes: 10 additions & 0 deletions internal/health/dependencies.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,16 @@ var HostRequiredDependencies = []Dependency{
Label: "OpenSSH",
Checks: []Check{BinaryExists{}, OpenSSHAvailable{}},
},
{
Binary: "git",
Label: "Git",
Checks: []Check{BinaryExists{
Severity: SeverityWarning,
Fix: &Fix{
Description: "Install Git and ensure its git executable is on PATH. See https://git-scm.com/downloads",
},
}},
},
{
Binary: "docker",
Label: "Container Engine",
Expand Down