Skip to content

feat: add git to topo health checks - #439

Draft
federicobozzini wants to merge 2 commits into
mainfrom
health-deps-git
Draft

feat: add git to topo health checks#439
federicobozzini wants to merge 2 commits into
mainfrom
health-deps-git

Conversation

@federicobozzini

Copy link
Copy Markdown
Contributor

Changes

  • what title says

Checklist

  • 🤖 This change is covered by tests as required.
  • 🤹 All required manual testing has been performed.
  • 📖 All documentation updates are complete.

@federicobozzini
federicobozzini requested a review from a team as a code owner September 2, 2026 15:05
@th3james

th3james commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

I wonder if this is getting a bit excessive and we're creating a big scary checklist with relatively poor signal-to-noise ratio. If we are going to do this is should be SeverityWarning because it's only necessary for topo clone with git, we still support dir:

@federicobozzini

Copy link
Copy Markdown
Contributor Author

Very reasonable 2088ba7

@muchzill4

muchzill4 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

I'd rather we didn't do this (just yet).

topo health right now is tightly integrated into deployment flow. Heck, even topo deploy tells you to run topo health if the deployment fails. Reporting git status might be confusing unless we somehow group the software health checks into respective flow groups (clone, deploy). I believe we should think more carefully before bolting on another check.

big scary checklist with relatively poor signal-to-noise ratio

Sums it up pretty nicely.

My preference would be to scope this change to README.md for now.

@federicobozzini
federicobozzini marked this pull request as draft September 7, 2026 09:45
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants