Repository navigation
New Sample - Set Focus - #701
Merged
Merged
Conversation
oblomov-dev
pushed a commit
that referenced
this pull request
Aug 4, 2026
Sample 443 was merged in #701 without the catalog update, so standard has been failing generate_overview_apps since. Adds the missing tile. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cpu46KEg8yScnPEVUKS8fL
oblomov-dev
added a commit
that referenced
this pull request
Aug 4, 2026
…PR (#704) * Regenerate the overview apps after the merge instead of blocking the PR The overview catalogs are generated from the folder tree and the class descriptions, so a stale catalog says nothing about the quality of a change - it only forced a mechanical follow-up commit before a branch could be merged. generate_overview_apps no longer runs on pull_request. It runs after the merge into standard, regenerates the catalogs there and pushes the result back, so a branch that adds or moves samples can be merged as is and standard heals itself. The push uses a deploy key (ACTION_KEY_SAMPLES, the pattern already used for ACTION_KEY_FRONTEND and ACTION_KEY_LOCAL) rather than the default GITHUB_TOKEN: standard is protected, so the pushing actor needs a bypass entry in its branch ruleset, and a GITHUB_TOKEN push would not re-trigger auto_cloud and auto_downport, leaving the cloud and 702 branches with the stale catalog. Until the secret is configured the workflow only verifies and fails on a diff, which is the previous behaviour. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cpu46KEg8yScnPEVUKS8fL * Regenerate the overview apps for the Set Cursor sample Sample 443 was merged in #701 without the catalog update, so standard has been failing generate_overview_apps since. Adds the missing tile. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cpu46KEg8yScnPEVUKS8fL * Push the regenerated catalogs with GITHUB_TOKEN instead of a deploy key A deploy key was never needed to write into this repository - the default GITHUB_TOKEN can do that with contents: write, and standard being protected requires a bypass entry on its branch ruleset either way, whichever credential pushes. The one thing the deploy key bought was that a push made with it starts further workflow runs, while a GITHUB_TOKEN push does not: auto_cloud and auto_downport would not react to the bot commit, so the cloud and 702 branches would keep the stale catalog until the next unrelated push to standard. workflow_dispatch is exempt from that restriction, so the two rebuilds are now dispatched explicitly after the push and both gain a workflow_dispatch trigger. That removes the secret, the key rollover and the ruleset caveat that deploy keys cannot be bypass actors under classic branch protection. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cpu46KEg8yScnPEVUKS8fL --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.