Skip to content

Regenerate the overview apps after the merge instead of blocking the PR - #704

Merged
oblomov-dev merged 3 commits into
standardfrom
claude/job-auf-rot-0dvx40
Aug 4, 2026
Merged

oblomov-dev merged 3 commits into
standardfrom
claude/job-auf-rot-0dvx40

Conversation

@oblomov-dev

@oblomov-dev oblomov-dev commented Aug 4, 2026 •

Copy link
Copy Markdown
Member

Summary

The overview catalogs are generated from the folder tree and the class descriptions, so a stale catalog says nothing about the quality of a change — it only forced a mechanical follow-up commit before a branch could be merged. generate_overview_apps now runs after the merge instead of on the pull request, so a branch that adds or moves samples can be merged as is and standard heals itself.

This also fixes the current red standard: #701 was merged without the catalog update, so the workflow has been failing on standard since (runs for #701 and #703).

Changes

generate_overview_apps no longer runs on pull_request. It runs on push to standard, regenerates the catalogs there and pushes the result back with the default GITHUB_TOKEN. That push starts no workflow run, so this does not loop.

The cloud and 702 rebuilds are dispatched explicitly. A push made with GITHUB_TOKEN does not start further workflow runs — GitHub's guard against recursive workflows — so auto_cloud and auto_downport would not react to the bot commit and the cloud and 702 branches would keep the stale catalog until the next unrelated push. workflow_dispatch is exempt from that restriction, so the job triggers both after pushing; each gains a workflow_dispatch trigger for that.

Adds the missing tile for sample 443 so standard is green again immediately.

AGENTS.md §4 now states that a stale catalog never blocks a pull request, while still recommending that contributors regenerate — it keeps the diff reviewable and saves the extra bot commit.

Follow-up needed to activate

standard is protected, so the push only works once the GitHub Actions app is a bypass actor on the standard branch ruleset. That is the only manual step. Until it is configured the job fails on a diff with an actionable message, which is exactly the previous behaviour — nothing breaks on merge.

An earlier revision of this branch used a deploy key. It turned out to buy only the workflow re-triggering, which workflow_dispatch covers, so the secret, its rollover and the caveat that deploy keys cannot be bypass actors under classic branch protection are all gone.

Verification

  • npx abaplint — 0 issues across 719 files
  • node scripts/check-agents-structure.js — passes
  • npm run launchpad produces no further diff
  • All three workflow files parse; triggers and permissions are as intended
  • The sync step was exercised against a scratch repository: no diff → exit 0, nothing dispatched; diff → commit pushed to standard and both rebuilds dispatched; diff with the push rejected (simulating the missing ruleset bypass) → exit 1 with the actionable message and no dispatch

🤖 Generated with Claude Code

https://claude.ai/code/session_01Cpu46KEg8yScnPEVUKS8fL

claude added 3 commits August 4, 2026 10:53
The overview catalogs are generated from the folder tree and the class
descriptions, so a stale catalog says nothing about the quality of a change -
it only forced a mechanical follow-up commit before a branch could be merged.

generate_overview_apps no longer runs on pull_request. It runs after the merge
into standard, regenerates the catalogs there and pushes the result back, so a
branch that adds or moves samples can be merged as is and standard heals
itself.

The push uses a deploy key (ACTION_KEY_SAMPLES, the pattern already used for
ACTION_KEY_FRONTEND and ACTION_KEY_LOCAL) rather than the default GITHUB_TOKEN:
standard is protected, so the pushing actor needs a bypass entry in its branch
ruleset, and a GITHUB_TOKEN push would not re-trigger auto_cloud and
auto_downport, leaving the cloud and 702 branches with the stale catalog. Until
the secret is configured the workflow only verifies and fails on a diff, which
is the previous behaviour.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cpu46KEg8yScnPEVUKS8fL
Sample 443 was merged in #701 without the catalog update, so standard has
been failing generate_overview_apps since. Adds the missing tile.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cpu46KEg8yScnPEVUKS8fL
A deploy key was never needed to write into this repository - the default
GITHUB_TOKEN can do that with contents: write, and standard being protected
requires a bypass entry on its branch ruleset either way, whichever credential
pushes.

The one thing the deploy key bought was that a push made with it starts further
workflow runs, while a GITHUB_TOKEN push does not: auto_cloud and auto_downport
would not react to the bot commit, so the cloud and 702 branches would keep the
stale catalog until the next unrelated push to standard.

workflow_dispatch is exempt from that restriction, so the two rebuilds are now
dispatched explicitly after the push and both gain a workflow_dispatch trigger.
That removes the secret, the key rollover and the ruleset caveat that deploy
keys cannot be bypass actors under classic branch protection.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cpu46KEg8yScnPEVUKS8fL
@oblomov-dev
oblomov-dev merged commit 95c01fa into standard Aug 4, 2026
7 checks passed
@oblomov-dev
oblomov-dev deleted the claude/job-auf-rot-0dvx40 branch August 4, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants