Repository navigation
Cap the LazyLoading card count, keep the client in new-tab links, fix two truncated job titles - #266
Merged
Merged
Conversation
Z2UI5_CL_SMPC_SAPUI5_008 showed "lobal Solutions Manager" and "Lead Markets Manage" in the org chart's QuickView - both truncated. They read "Global Solutions Manager" and "Lead Markets Manager" now. src/03 is a collection, not a port, so there is no data fidelity to keep. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Z2UI5_CL_SMPC_APP_342 accepted any count up to nine digits and built one row per card in a table the session holds and every round-trip carries, so a typed 999999999 exhausted the application server. The original builds the Cards in the browser; the port now stops at 100, declared as a NOTE in the sidecar, and builds exactly what the original builds below that. Overview, STATUS.md and SAMPLES.md regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
The overview's "open in a new tab" URL (start_url_of, written by scripts/lib/overview-emit.mjs) was origin + path + app_start only. A new tab is a new session, so on a system where the user works in a client other than the default one it logged on to the default client. The URL now carries sap-client and sap-language over from the current one. Overview regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
oblomov-dev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One commit per fix:
999999999exhausted the application server. The original builds its Cards in the browser. The port now stops at 100 (MAX_CARDS), declared as aNOTEin the sidecar, and builds exactly what the original builds below that. The overview app, STATUS.md and SAMPLES.md are regenerated.start_url_of, written byscripts/lib/overview-emit.mjs): the URL was only origin + path +app_start. A new tab is a new session, so a user working in a client other than the system's default was logged on to the default client. The URL now carriessap-clientandsap-languageover from the current URL. The overview is regenerated.Checked locally:
npm run gates, the rest ofnpm run check(app-rules, keywords, summary, origin,npm test),abaplint(standard + cloud),view-gates --strict --only 342,check:collectionandcheck:overview, all green.Round-4 item "Z2UI5_CL_SMPC_APP_574 SEARCH loses row selections" was verified and left unchanged. The original sets
rememberSelections="false", so a filter clears the selection there too. The port is faithful.🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt