refactor: manage CMS assets, delete outdated assets - #535
Draft
wesleyboar wants to merge 64 commits into
Draft
Conversation
TACC/Core-CMS#1033 automates redirect logic. #529 was stepping stone. But this PR does not need those steps nor old code.
The ad-hoc.js definitely works. I use it on TACC site live, and other Core-CMS sites.
This has been working via Core-CMS for almost a year. TACC/Core-CMS#838
This file is nto the same code as Core-CMS. No need for it. By deleting this one, it will nto be copied. The default one in Core-CMS image will be used.
Available since TACC/Core-CMS#611. Updated in TACC/Core-CMS#996.
Update TUP-CMS styles to respect new Core-CMS styles: See TACC/Core-CMS#1028 Then TACC/Core-CMS#1029 Delete https://tacc.utexas.edu/admin/djangocms_snippet/snippet/172/
So that CMS nav width does not increase with CMS font.
Core-Styles flipped font to Benton (CMS) then back to Roboto (Portal).
This reverts commit 90be726. Core-CMS brings hover states (color of SVG changes to brand color of that social media).
No reason to override this. If CMS admin wants to use `<small>`, let her. I just tweak font-size.
Core-Styles was updated to also use `--max-width: auto`. Thus, TUP CMS need not set it.
Core-CMS offers —
```css
[class*="logos--"] a svg {
display: block;
}
```
— which makes `vertical-align: middle`[^1] have no effect.
[^1]: Even Bootstrap's `vertical-align: middle` has no effect.
Core-Styles fixed logo vertical alignment.
2 tasks
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Apr 1, 2026
## Overview Adds a Bootstrap 4 extension for the [media object](https://getbootstrap.com/docs/4.6/components/media-object/), `.media-link` modifier which aligns thumbnail and body. Demo has variant markup for Bootstrap and TACC. ## Related - used by TACC/tup-ui#535 ## Changes - **added** stylesheet - **added** demo ## Testing 1. Run `npm run build:css` and confirm `dist/core-styles.bootstrap4.css` includes `.media-link`. 2. Run `npm start` (or `npm run build:demo`) and open the Bootstrap 3. [**Media** pattern](http://localhost:3000/components/detail/media); confirm examples match intended layout. ## UI <img width="900" height="475" alt="boostrap media extended by tacc" src="https://github.com/user-attachments/assets/100b5780-146c-4b71-91db-3dfb1e97c6fd" />
Added a temporary link to load Core-Styles for media component. Will be deleted when newer Core-Styles is loaded.
Not legible enough on white background. Was legible enough on black background, and still is.
Core-Styles colors footer text.
Removed obsolete CSS link for Core-Styles and updated TODO comments.
wesleyboar
added a commit
to TACC/Core-CMS-Custom
that referenced
this pull request
Jul 31, 2026
## Overview Update `tup/html/` with every snippet change from a currently-open tup-ui PR. ## Related - requires #559 - migrates snippet changes from: - TACC/tup-ui#568 - TACC/tup-ui#325 - TACC/tup-ui#535 - TACC/tup-ui#557 - TACC/tup-ui#562 - TACC/tup-ui#565 - TACC/tup-ui#566 ## Changes - **added** `embed-vislab-*.html` <sup>latest versions from:</sup> - TACC/tup-ui#568 - **updated** `css-ad-hoc-styles.html` <sup>hand-composed from:</sup> - TACC/tup-ui#325 - TACC/tup-ui#535 - TACC/tup-ui#557 - TACC/tup-ui#562 - TACC/tup-ui#565 - **updated** `js-ad-hoc-scripts.html` <sup>hand-composed from:</sup> - TACC/tup-ui#535 - TACC/tup-ui#566 ## Testing 1. Compare `embed-vislab-*` files against the branch of TACC/tup-ui#568 to confirm content matches. 2. For `css-ad-hoc-styles.html` and `js-ad-hoc-scripts.html`, compare against each contributing PR's diff to confirm every intended change made it in.
This was referenced Jul 31, 2026
wesleyboar
force-pushed
the
feat/update-core-cms-and-core-styles
branch
from
August 3, 2026 20:10
785f64f to
1fdda33
Compare
wesleyboar
added a commit
to TACC/Core-CMS-Custom
that referenced
this pull request
Aug 3, 2026
…pment (#561) ## Overview Migrates `c-news.css`, `c-news--read.css`, and `c-news--list.css` out of [TACC/tup-ui's `for-core-styles/` folder](https://github.com/TACC/tup-ui/tree/v1.2.3/apps/tup-cms/src/taccsite_custom/tup_cms/static/tup_cms/css/for-core-styles). <details> These are genuine Core-Styles gaps discovered while building tup-ui — not tup-specific overrides — so this repo's `generic_assets/` (not `tup/`) is the right home, since it's what other projects actually check for known Core-Styles/Core-CMS gaps. </details> ## Related - adds to #563 - required by tup-ui#570 Includes changes from: - TACC/tup-ui#325 Does not include `c-feed-list.css` cuz it is deleted in: - TACC/tup-ui#325 - TACC/tup-ui#535 ## Changes - **added** `generic_assets/css/c-news.css` - **added** `generic_assets/css/c-news--read.css` - **added** `generic_assets/css/c-news--list.css` - **added** `generic_assets/css/core-styles-feats.css` (imports `c-news.css` into `layer(base)`, since a plain `<link>` can't assign a layer) - **updated** `tup/html/css-ad-hoc-styles.html` to load `core-styles-feats.css`, instead of adding another raw `<style>@import>` block to an already-large snippet ## Testing 1. Confirm each file's content matches tup-ui's current `for-core-styles/components/` copy, with tup-ui#325's diff applied to `c-news.css` and `c-news--read.css`. <!-- ## Notes … -->
wesleyboar
added a commit
that referenced
this pull request
Aug 3, 2026
…bundle c-feed-list.css was tup-ui's local override of a component now provided by Core-Styles itself (>=v2.44.0; tup-ui is on ^2.54.1) — matches what tup-ui#325 and #535 already do independently. With all 4 files gone from for-core-styles/components/, the directory (and its README) has nothing left, and tup-cms.for-core-styles.css is just empty ITCSS section placeholders — so delete both, and drop the dead <link> to the bundle from assets_custom.html.
wesleyboar
added a commit
that referenced
this pull request
Aug 3, 2026
Unlike this PR's other deletions, these two were never migrated to Core-CMS-Custom (they're djangocms-snippet "template"-field templates, not manually-synced reference copies, per the original migration's notes). They're deleted here because #535 already deletes them independently — the external-post-link and redirect behavior they provide is now handled by Core-CMS itself.
This was referenced Aug 3, 2026
…nd new adjust-logo.css Both are now versioned in Core-CMS-Custom (TACC/Core-CMS-Custom#564) instead of here; keep them untouched/absent here so tup-ui#571 doesn't conflict with this PR.
wesleyboar
added a commit
to TACC/Core-CMS-Custom
that referenced
this pull request
Aug 3, 2026
## Overview Migrates CSS/JS assets (that `tup/html/css-ad-hoc-styles.html` and `js-ad-hoc-scripts.html` load) from [TACC/tup-ui] to here. <details> [TACC/tup-ui]: https://github.com/TACC/ The snippets files were already migrated (#559, #560); this closes the loop so those snippets' `<link>`/`<script>` tags can point at this repo's CDN pins instead of tup-ui's. </details> ## Related - adds to #563 - integrates changes from: - TACC/tup-ui#566 - TACC/tup-ui#535 - TACC/tup-ui#562 > [!IMPORTANT] > **Follow-up:** Repoint `tup/html/css-ad-hoc-styles.html` and `js-ad-hoc-scripts.html`'s CDN URLs at this repo (not done in this PR). ## Changes - **added** `tup/css/ad-hoc/` (many files) - **added** `tup/js/ad-hoc.js` - **added** `tup/js/ad-hoc/manage-participants-field-required-attr.js` - **added** `tup/css/ad-hoc/hide-blog-list-back-link.css` (from TACC/tup-ui#562, open) - **added** `tup/css/ad-hoc/adjust-logo.css` (from TACC/tup-ui#535, open) - **updated** `navbar-width-horz-scrollbar.css` ## Testing 1. Confirm each file's content matches TACC/tup-ui's current copy exactly **except**: - `navbar-width-horz-scrollbar.css` matches TACC/tup-ui#535's branch - `adjust-logo.css` matches TACC/tup-ui#535's branch (doesn't exist on tup-ui `main`) - `hide-blog-list-back-link.css` matches TACC/tup-ui#562's branch (doesn't exist on tup-ui `main`) - `ad-hoc.js`/`manage-participants-field-required-attr.js` matches the commit already pinned in the live snippet, TACC/tup-ui@0c0beee5
This was referenced Aug 4, 2026
wesleyboar
added a commit
to TACC/Core-CMS-Custom
that referenced
this pull request
Aug 4, 2026
## Overview Migrates tup-ui's `for-tup-cms/` to here at `/tup/`. ## Related - adds to #563 - required by TACC/tup-ui#573 Includes changes from: - TACC/tup-ui#535 Does not include `breadcrumbs` cuz it is delete in: - TACC/tup-ui#535 ## Changes - **added** `tup/css/cms.css` - **added** `tup/css/_imports/**/*.css` - **added** `tup/css/_imports/components/banner` - **added** `tup/img/logo-*.svg` - **updated** `tup/README.md` ## Testing 1. Confirm each migrated file's content matches its tup-ui `for-tup-cms/`/`org_logos/` counterpart exactly (renames, and the breadcrumbs/footer drops, aside). 2. Confirm `tup/css/cms.css`'s `@import` list matches tup-ui's `tup-cms.for-tup-cms.css` 1-to-1 (minus the breadcrumbs import) just repathed to `./_imports/`.
jarosenb
pushed a commit
that referenced
this pull request
Aug 10, 2026
* chore(cms): delete snippets migrated to Core-CMS-Custom These 9 template copies were reference-only records of djangocms-snippet content per this repo's "Save Snippets" convention. They now live in Core-CMS-Custom (TACC/Core-CMS-Custom#559) with no open PR here still editing them, so the local copies are redundant. * chore(cms): delete remaining snippets migrated to Core-CMS-Custom css-ad-hoc-styles.html and js-ad-hoc-scripts.html were held back from the prior commit because open PRs (#325, #535, #557, #562, #565, #566) still edited them here. Those PRs are being updated to drop their edits to these two files in favor of Core-CMS-Custom (TACC/Core-CMS-Custom#560), so the local copies can go too. * chore(cms): delete redirect.html and open-external-post.html Unlike this PR's other deletions, these two were never migrated to Core-CMS-Custom (they're djangocms-snippet "template"-field templates, not manually-synced reference copies, per the original migration's notes). They're deleted here because #535 already deletes them independently — the external-post-link and redirect behavior they provide is now handled by Core-CMS itself.
jarosenb
added a commit
that referenced
this pull request
Aug 10, 2026
* chore(cms): delete c-news.css files, migrated to Core-CMS-Custom c-news.css, c-news--read.css, and c-news--list.css were general Core-Styles gaps found during tup-ui development, not tup-specific overrides, so they've moved to Core-CMS-Custom (TACC/Core-CMS-Custom#561) where other projects can find and use them. Loading moves to the ad-hoc CSS snippet (edited live in the CMS admin, already migrated to TACC/Core-CMS-Custom#559/#560) instead of assets_custom.html — no tup-ui code needs to load this CSS anymore. * chore(cms): delete c-feed-list.css and the now-empty for-core-styles bundle c-feed-list.css was tup-ui's local override of a component now provided by Core-Styles itself (>=v2.44.0; tup-ui is on ^2.54.1) — matches what tup-ui#325 and #535 already do independently. With all 4 files gone from for-core-styles/components/, the directory (and its README) has nothing left, and tup-cms.for-core-styles.css is just empty ITCSS section placeholders — so delete both, and drop the dead <link> to the bundle from assets_custom.html. --------- Co-authored-by: Jake Rosenberg <jrosenberg@tacc.utexas.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Many changes were subsumed into #537.
Note
Optional new tasks:
--fat&__identityCore-Styles#630Caution
Untested.
Note
After deploy:
Related
Changes
c-feed-listmigrated to Core-CMS (Core-Styles@v2.44.0, Core-CMS@v4.33)tup-cms.for-*.cssfrom template toPORTAL_STYLESplain.htmltemplate migrated to Core-CMSsettings_custom.pydetails#cms-footercolormanaged by Core-StylesMany changes were subsumed into #537.
html_page_idfromportaltopage-portalassets_core_projecttoassets_projectsettings_custom.pydetailsmoves styling for footer to new appropriate stylesheetTesting & UI
Core-CMS
verify at least two external articles per page
/about/tours/request/tup-cms.for-core-cms.csstup-cms.for-core-style.csstup-cms.for-tup-cms.css/news/latest-news//systems/all/to test on prod, remove/comment snippet #172
frontera, should not showFronterain HTML of titlesee screenshot of
Lccf(before it was renamed toLCCF)<h2>is brown and an<h3>is white or black(see demo videos)
Core-Styles
#FFFFFFor#F4F4F4.(value uses
var, color depends on Core-Styles version)Otherwise, nothing to test, because the rest is fixes or opt-in features.
Notes
Note
Reverted this PR's edits to
css-ad-hoc-styles.htmlandjs-ad-hoc-scripts.html— both snippets are now versioned in Core-CMS-Custom and are being deleted from this repo in #569.Note
Reverted this PR's edit to
navbar-width-horz-scrollbar.cssand dropped its newadjust-logo.css— both are now versioned in Core-CMS-Custom (TACC/Core-CMS-Custom#564) instead of here.