Skip to content

refactor: manage CMS assets, delete outdated assets - #535

Draft
wesleyboar wants to merge 64 commits into
mainfrom
feat/update-core-cms-and-core-styles
Draft

refactor: manage CMS assets, delete outdated assets#535
wesleyboar wants to merge 64 commits into
mainfrom
feat/update-core-cms-and-core-styles

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Feb 5, 2026

Copy link
Copy Markdown
Member

Overview

  1. Deletes code that was migrated to Core-CMS and Core-Styles.
  2. Moves custom mgmt. of assets to standard snippets and settings.
Many changes were subsumed into #537.
  1. Refactors outdated method to install Blog/News.
  2. Updates Core-CMS v4.28.2 → v4.39.0 & Core-Styles v2.39.0 → v2.54.0.

Note

Optional new tasks:

Caution

Untested.

Note

After deploy:

Related

Changes

Many changes were subsumed into #537.
  • updates html_page_id from portal to page-portal
  • updates assets_core_project to assets_project
  • refactors how to enable and configure Blog/News
  • updates settings_custom.py details
  • moves styling for footer to new appropriate stylesheet
  • updates styling for footer (mirrors fix: a11y issues (+ update core-cms & core-styles) #537)
  • updates to newer Core-CMS
  • updates to newer Core-Styles

Testing & UI

Core-CMS

  1. header, style and layout unchanged
  2. page News, feed's external articles all still open different website
    verify at least two external articles per page
  3. plugin Form, forms can be submitted e.g.
    • /about/tours/request/
  4. assets, custom stylesheets are loaded:
    • tup-cms.for-core-cms.css
    • tup-cms.for-core-style.css
    • tup-cms.for-tup-cms.css
  5. page Search, search results are styled
  6. page Training & Events, has same feed styles
  7. page User Updates, has same feed styles
    • especially, verify each update has no byline
  8. script HotJar, tracking is still active
  9. pages that are deeply nested, still disable 2nd breadcrumb e.g.
    • /news/latest-news/
    • /systems/all/
  10. plugin Icon, editor form has same style and still works
  11. plugin Link/Button, renders buttons with Core-Styles UI
  12. footer, social media icons unchanged
    to test on prod, remove/comment snippet #172
  13. footer, social media icons change color (white to light gray) on hover
  14. page News, style and layout are unchanged.
  15. page News article (any), style and layout are unchanged.
  16. page News article (any), publish time options are changed.
  17. plugins, new ones available:
    • "Latest Blog Articles"
    • "Featured Posts"
  18. page News article (any), updated editor form options:
  19. page News tagged frontera, should not show Frontera in HTML of title
    see screenshot of Lccf (before it was renamed to LCCF)
  20. portal, "Cortal" icons still load e.g. sidebar icons
  21. misc pages, an <h2> is brown and an <h3> is white or black
  22. plugin "Link / Button":
    • not "⚠️ " in title
    • not "⚠️ This plugin is deprecated." message in form
    • has "Type:" and "Size:" with Core-Styles options
    • not "Context:" nor "Size:" previews
    • not "Outline" nor "Block" checkboxes
    • has "Icon left" and "Icon right" icon selection dropdowns
    • renders correctly based on options chosen
      (see demo videos)

Core-Styles

  1. page News, style and layout are unchanged.
  2. page News article (any), style and layout are unchanged.
  3. footer white text color is #FFFFFF or #F4F4F4.
    (value uses var, color depends on Core-Styles version)

Otherwise, nothing to test, because the rest is fixes or opt-in features.

Notes

Note

Reverted this PR's edits to css-ad-hoc-styles.html and js-ad-hoc-scripts.html — both snippets are now versioned in Core-CMS-Custom and are being deleted from this repo in #569.

Note

Reverted this PR's edit to navbar-width-horz-scrollbar.css and dropped its new adjust-logo.css — both are now versioned in Core-CMS-Custom (TACC/Core-CMS-Custom#564) instead of here.

TACC/Core-CMS#1033 automates redirect logic.

#529 was stepping stone.

But this PR does not need those steps nor old code.
The ad-hoc.js definitely works.

I use it on TACC site live, and other Core-CMS sites.
This has been working via Core-CMS for almost a year.

TACC/Core-CMS#838
This file is nto the same code as Core-CMS. No need for it.

By deleting this one, it will nto be copied.

The default one in Core-CMS image will be used.
So that CMS nav width does not increase with CMS font.
Core-Styles flipped font to Benton (CMS) then back to Roboto (Portal).
This reverts commit 90be726.

Core-CMS brings hover states (color of SVG changes to brand color of that social media).
No reason to override this.

If CMS admin wants to use `<small>`, let her. I just tweak font-size.
Core-Styles was updated to also use `--max-width: auto`.

Thus, TUP CMS need not set it.
Core-CMS offers —

```css
[class*="logos--"] a svg {
  display: block;
}
```

— which makes `vertical-align: middle`[^1] have no effect.

[^1]: Even Bootstrap's `vertical-align: middle` has no effect.
Core-Styles fixed logo vertical alignment.
wesleyboar added a commit to TACC/Core-Styles that referenced this pull request Apr 1, 2026
## Overview

Adds a Bootstrap 4 extension for the [media
object](https://getbootstrap.com/docs/4.6/components/media-object/),
`.media-link` modifier which aligns thumbnail and body.

Demo has variant markup for Bootstrap and TACC.

## Related

- used by TACC/tup-ui#535

## Changes

- **added** stylesheet
- **added** demo

## Testing

1. Run `npm run build:css` and confirm `dist/core-styles.bootstrap4.css`
includes `.media-link`.
2. Run `npm start` (or `npm run build:demo`) and open the Bootstrap 3.
[**Media** pattern](http://localhost:3000/components/detail/media);
confirm examples match intended layout.

## UI

<img width="900" height="475" alt="boostrap media extended by tacc"
src="https://github.com/user-attachments/assets/100b5780-146c-4b71-91db-3dfb1e97c6fd"
/>
Added a temporary link to load Core-Styles for media component. Will be deleted when newer Core-Styles is loaded.
Not legible enough on white background.

Was legible enough on black background, and still is.
Core-Styles colors footer text.
Removed obsolete CSS link for Core-Styles and updated TODO comments.
wesleyboar added a commit to TACC/Core-CMS-Custom that referenced this pull request Jul 31, 2026
## Overview

Update `tup/html/` with every snippet change from a currently-open
tup-ui PR.

## Related

- requires #559
- migrates snippet changes from:
    - TACC/tup-ui#568
    - TACC/tup-ui#325
    - TACC/tup-ui#535
    - TACC/tup-ui#557
    - TACC/tup-ui#562
    - TACC/tup-ui#565
    - TACC/tup-ui#566

## Changes

- **added** `embed-vislab-*.html`
    <sup>latest versions from:</sup>
    - TACC/tup-ui#568
- **updated** `css-ad-hoc-styles.html`
    <sup>hand-composed from:</sup>
    - TACC/tup-ui#325
    - TACC/tup-ui#535
    - TACC/tup-ui#557
    - TACC/tup-ui#562
    - TACC/tup-ui#565
- **updated** `js-ad-hoc-scripts.html`
    <sup>hand-composed from:</sup>
    - TACC/tup-ui#535
    - TACC/tup-ui#566

## Testing

1. Compare `embed-vislab-*` files against the branch of
TACC/tup-ui#568 to confirm content matches.
2. For `css-ad-hoc-styles.html` and `js-ad-hoc-scripts.html`, compare
against each contributing PR's diff to confirm every intended change
made it in.
@wesleyboar
wesleyboar force-pushed the feat/update-core-cms-and-core-styles branch from 785f64f to 1fdda33 Compare August 3, 2026 20:10
…-hoc-scripts.html

Both snippets are being deleted from this repo in favor of Core-CMS-Custom
(#569); keep them untouched here so #569 doesn't conflict with this PR.
wesleyboar added a commit to TACC/Core-CMS-Custom that referenced this pull request Aug 3, 2026
…pment (#561)

## Overview

Migrates `c-news.css`, `c-news--read.css`, and `c-news--list.css` out of
[TACC/tup-ui's `for-core-styles/`
folder](https://github.com/TACC/tup-ui/tree/v1.2.3/apps/tup-cms/src/taccsite_custom/tup_cms/static/tup_cms/css/for-core-styles).

<details>

These are genuine Core-Styles gaps discovered while building tup-ui —
not tup-specific overrides — so this repo's `generic_assets/` (not
`tup/`) is the right home, since it's what other projects actually check
for known Core-Styles/Core-CMS gaps.

</details>

## Related

- adds to #563
- required by tup-ui#570

Includes changes from:
- TACC/tup-ui#325

Does not include `c-feed-list.css` cuz it is deleted in:
- TACC/tup-ui#325
- TACC/tup-ui#535

## Changes

- **added** `generic_assets/css/c-news.css`
- **added** `generic_assets/css/c-news--read.css`
- **added** `generic_assets/css/c-news--list.css`
- **added** `generic_assets/css/core-styles-feats.css` (imports
`c-news.css` into `layer(base)`, since a plain `<link>` can't assign a
layer)
- **updated** `tup/html/css-ad-hoc-styles.html` to load
`core-styles-feats.css`, instead of adding another raw `<style>@import>`
block to an already-large snippet

## Testing

1. Confirm each file's content matches tup-ui's current
`for-core-styles/components/` copy, with tup-ui#325's diff applied to
`c-news.css` and `c-news--read.css`.

<!--
## Notes

…
-->
wesleyboar added a commit that referenced this pull request Aug 3, 2026
…bundle

c-feed-list.css was tup-ui's local override of a component now provided
by Core-Styles itself (>=v2.44.0; tup-ui is on ^2.54.1) — matches what
tup-ui#325 and #535 already do independently.

With all 4 files gone from for-core-styles/components/, the directory
(and its README) has nothing left, and tup-cms.for-core-styles.css is
just empty ITCSS section placeholders — so delete both, and drop the
dead <link> to the bundle from assets_custom.html.
wesleyboar added a commit that referenced this pull request Aug 3, 2026
Unlike this PR's other deletions, these two were never migrated to
Core-CMS-Custom (they're djangocms-snippet "template"-field templates,
not manually-synced reference copies, per the original migration's
notes). They're deleted here because #535 already deletes them
independently — the external-post-link and redirect behavior they
provide is now handled by Core-CMS itself.
…nd new adjust-logo.css

Both are now versioned in Core-CMS-Custom (TACC/Core-CMS-Custom#564)
instead of here; keep them untouched/absent here so tup-ui#571 doesn't
conflict with this PR.
wesleyboar added a commit to TACC/Core-CMS-Custom that referenced this pull request Aug 3, 2026
## Overview

Migrates CSS/JS assets (that `tup/html/css-ad-hoc-styles.html` and
`js-ad-hoc-scripts.html` load) from [TACC/tup-ui] to here.

<details>

[TACC/tup-ui]: https://github.com/TACC/

The snippets files were already migrated (#559, #560); this closes the
loop so those snippets' `<link>`/`<script>` tags can point at this
repo's CDN pins instead of tup-ui's.

</details>

## Related

- adds to #563
- integrates changes from:
    - TACC/tup-ui#566
    - TACC/tup-ui#535
    - TACC/tup-ui#562

> [!IMPORTANT]
> **Follow-up:** Repoint `tup/html/css-ad-hoc-styles.html` and
`js-ad-hoc-scripts.html`'s CDN URLs at this repo (not done in this PR).

## Changes

- **added** `tup/css/ad-hoc/` (many files)
- **added** `tup/js/ad-hoc.js`
- **added** `tup/js/ad-hoc/manage-participants-field-required-attr.js`
- **added** `tup/css/ad-hoc/hide-blog-list-back-link.css` (from
TACC/tup-ui#562, open)
- **added** `tup/css/ad-hoc/adjust-logo.css` (from TACC/tup-ui#535,
open)
- **updated** `navbar-width-horz-scrollbar.css`

## Testing

1. Confirm each file's content matches TACC/tup-ui's current copy
exactly **except**:
    - `navbar-width-horz-scrollbar.css` matches TACC/tup-ui#535's branch
- `adjust-logo.css` matches TACC/tup-ui#535's branch (doesn't exist on
tup-ui `main`)
- `hide-blog-list-back-link.css` matches TACC/tup-ui#562's branch
(doesn't exist on tup-ui `main`)
- `ad-hoc.js`/`manage-participants-field-required-attr.js` matches the
commit already pinned in the live snippet, TACC/tup-ui@0c0beee5
wesleyboar added a commit to TACC/Core-CMS-Custom that referenced this pull request Aug 4, 2026
## Overview

Migrates tup-ui's `for-tup-cms/` to here at `/tup/`.

## Related

- adds to #563
- required by TACC/tup-ui#573

Includes changes from:
- TACC/tup-ui#535

Does not include `breadcrumbs` cuz it is delete in:
- TACC/tup-ui#535

## Changes

- **added** `tup/css/cms.css`
- **added** `tup/css/_imports/**/*.css`
- **added** `tup/css/_imports/components/banner`
- **added** `tup/img/logo-*.svg`
- **updated** `tup/README.md`

## Testing

1. Confirm each migrated file's content matches its tup-ui
`for-tup-cms/`/`org_logos/` counterpart exactly (renames, and the
breadcrumbs/footer drops, aside).
2. Confirm `tup/css/cms.css`'s `@import` list matches tup-ui's
`tup-cms.for-tup-cms.css` 1-to-1 (minus the breadcrumbs import) just
repathed to `./_imports/`.
jarosenb pushed a commit that referenced this pull request Aug 10, 2026
* chore(cms): delete snippets migrated to Core-CMS-Custom

These 9 template copies were reference-only records of djangocms-snippet
content per this repo's "Save Snippets" convention. They now live in
Core-CMS-Custom (TACC/Core-CMS-Custom#559) with no open PR here still
editing them, so the local copies are redundant.

* chore(cms): delete remaining snippets migrated to Core-CMS-Custom

css-ad-hoc-styles.html and js-ad-hoc-scripts.html were held back from the
prior commit because open PRs (#325, #535, #557, #562, #565, #566) still
edited them here. Those PRs are being updated to drop their edits to these
two files in favor of Core-CMS-Custom (TACC/Core-CMS-Custom#560), so the
local copies can go too.

* chore(cms): delete redirect.html and open-external-post.html

Unlike this PR's other deletions, these two were never migrated to
Core-CMS-Custom (they're djangocms-snippet "template"-field templates,
not manually-synced reference copies, per the original migration's
notes). They're deleted here because #535 already deletes them
independently — the external-post-link and redirect behavior they
provide is now handled by Core-CMS itself.
jarosenb added a commit that referenced this pull request Aug 10, 2026
* chore(cms): delete c-news.css files, migrated to Core-CMS-Custom

c-news.css, c-news--read.css, and c-news--list.css were general
Core-Styles gaps found during tup-ui development, not tup-specific
overrides, so they've moved to Core-CMS-Custom (TACC/Core-CMS-Custom#561)
where other projects can find and use them.

Loading moves to the ad-hoc CSS snippet (edited live in the CMS admin,
already migrated to TACC/Core-CMS-Custom#559/#560) instead of
assets_custom.html — no tup-ui code needs to load this CSS anymore.

* chore(cms): delete c-feed-list.css and the now-empty for-core-styles bundle

c-feed-list.css was tup-ui's local override of a component now provided
by Core-Styles itself (>=v2.44.0; tup-ui is on ^2.54.1) — matches what
tup-ui#325 and #535 already do independently.

With all 4 files gone from for-core-styles/components/, the directory
(and its README) has nothing left, and tup-cms.for-core-styles.css is
just empty ITCSS section placeholders — so delete both, and drop the
dead <link> to the bundle from assets_custom.html.

---------

Co-authored-by: Jake Rosenberg <jrosenberg@tacc.utexas.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant