Skip to content

chore(cms): delete for-tup-cms (moved to diff repo) - #573

Merged
jarosenb merged 3 commits into
mainfrom
chore/delete-for-tup-cms-migrated-to-core-cms-custom
Aug 10, 2026
Merged

chore(cms): delete for-tup-cms (moved to diff repo)#573
jarosenb merged 3 commits into
mainfrom
chore/delete-for-tup-cms-migrated-to-core-cms-custom

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Aug 4, 2026

Copy link
Copy Markdown
Member

Overview

  • Deletes for-tup-cms/ whcih are now versioned in TACC/Core-CMS-Custom instead of here.
  • Repoints assets_custom.html and PORTAL_LOGO at Core-CMS-Custom's CDN.

Related

Changes

  • deleted css/for-tup-cms
  • deleted js/modules/breadcrumbs.js
  • deleted img/org_logos/
  • updated assets_custom.html
  • updated PORTAL_LOGO

Testing

  1. Confirm every deleted file's last content matches its counterpart in Core-CMS-Custom's tup/css/_imports/, tup/css/cms.css, tup/img/logo-*.svg (s-breadcrumbs.css/breadcrumbs.js were dropped there too, not migrated — see feat: vislab form & cal - snippets #568's notes).
  2. Confirm TUP CMS pages render identically: breadcrumb de-linking behavior (via Core-CMS's built-in logic), header logo, and all for-tup-cms component styling — footer, news/blog tweaks, layered-image sections, etc.
  3. Confirm header logo loads from the CDN and looks correct.

Notes

for-core-cms/ and for-core-styles/ are untouched here — those are handled separately by #570/#572.

Deletes for-tup-cms/, its manifest, breadcrumbs.js, and org_logos,
now versioned in Core-CMS-Custom's tup/. Repoints assets_custom.html
and PORTAL_LOGO at Core-CMS-Custom's CDN.

Related: TACC/Core-CMS-Custom#568
Core-CMS-Custom#568 dropped breadcrumbs.js/s-breadcrumbs.css instead
of migrating them — Core-CMS's nav_cms_breadcrumbs.html already does
2nd-crumb de-linking (different conditions, but redundant enough to
drop rather than maintain two copies). Nothing to load in its place.
@wesleyboar wesleyboar changed the title chore(tup-cms): delete for-tup-cms (moved to diff repo) chore(cms): delete for-tup-cms (moved to diff repo) Aug 4, 2026
wesleyboar added a commit to TACC/Core-CMS-Custom that referenced this pull request Aug 4, 2026
## Overview

Migrates tup-ui's `for-tup-cms/` to here at `/tup/`.

## Related

- adds to #563
- required by TACC/tup-ui#573

Includes changes from:
- TACC/tup-ui#535

Does not include `breadcrumbs` cuz it is delete in:
- TACC/tup-ui#535

## Changes

- **added** `tup/css/cms.css`
- **added** `tup/css/_imports/**/*.css`
- **added** `tup/css/_imports/components/banner`
- **added** `tup/img/logo-*.svg`
- **updated** `tup/README.md`

## Testing

1. Confirm each migrated file's content matches its tup-ui
`for-tup-cms/`/`org_logos/` counterpart exactly (renames, and the
breadcrumbs/footer drops, aside).
2. Confirm `tup/css/cms.css`'s `@import` list matches tup-ui's
`tup-cms.for-tup-cms.css` 1-to-1 (minus the breadcrumbs import) just
repathed to `./_imports/`.
@jarosenb
jarosenb merged commit cfa1055 into main Aug 10, 2026
1 check passed
@jarosenb
jarosenb deleted the chore/delete-for-tup-cms-migrated-to-core-cms-custom branch August 10, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants