feat: CMD-187 autocreate search page - #885
Closed
wesleyboar wants to merge 67 commits into
Closed
Conversation
So that it can be loaded from CDN. Use cases are: - if search template is broken - for custom search page - for non-Core website
Compared to "cms-search", "google-search" is: - more accurate - more obvious to those not familiar with Core-CMS
So dev sees 'google-search' from CSS before seeing it in HTML `id` attr.
Caused server error.
wesleyboar
marked this pull request as ready for review
October 22, 2024 23:37
This had create dbreadcrumsb before.
Final markup undecided, so keep it simple, and easy to understand.
* deps: core-styles v2.46.1 * refactor: u-image-zoom via core-styles
* fix: space under span.u-image-zoom img * deps: core-styles v2.46.2
* feat: snippet to redirect external article * fix: load Core-CMS script not tup-ui script
Member
Author
|
Reviewers removed for now. Important Incomplete because there is a suggestion (which I agree with) to use a custom migration. |
wesleyboar
added a commit
to TACC/CTRN-CMS
that referenced
this pull request
Jan 27, 2026
CTRN had used (unmerged) TACC/Core-CMS#885. That means it has remnant code of a search_page app.
Added styles to fix link UI and UX.
Added styles to fix MORE link UI and UX.
- accompanies #1089 - mirrors TACC/tup-ui@eb93d55
wesleyboar
force-pushed
the
feat/template-and-setting-for-google-search
branch
from
February 23, 2026 19:04
75768fe to
846e35e
Compare
Member
Author
|
Important Replaced by #1129. |
wesleyboar
added a commit
that referenced
this pull request
Jul 27, 2026
## Overview Rebuilds the search feature on current `main` instead of stale `release/v4.36.X`. > [!WARNING] > First run on a fresh database will crash `manage.py migrate` itself, because `apps/search_page/apps.py`'s `ready()` hook queries `cms_page` before it exists. Workaround: set `SEARCH_PAGE_AUTO_SETUP = False`, migrate, then set it back to `True` and restart. [Details.](#885 (review)) > [!IMPORTANT] > Should instead: > - [Use a custom migration.](#885 (review)) > - (and/or) Create a [Core-CMS plugin](https://github.com/search?q=org%3ATACC+%22Core-CMS-Plugin%22&type=repositories) (from [TACC/Django-App](https://github.com/TACC/Django-App)). ## Related - replaces #1129 ## Changes - **rebuilt** branch from `main` + cherry-picked search-only commits - **dropped** unrelated inherited commits (favicons, breadcrumbs, image-zoom, etc.) ## Testing / UI See #1129.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
For latest attempt, see #1216.
Overview
Support a Google Search page with less effort.
What Effort?
Every Time:
code→ ID.SEARCHsettings.Previously:
/searchpage.Now, Instead:
Important
Incomplete because there is a suggestion (which I agree with) to use a custom migration.
Caution
Do not merge.
Warning
Successful run requires two deploys. Help wanted.
Related
Instances:
Private, so no results.
Private, but has results from public LCCF.
Private still, so no results.
Changes
search_pageappSEARCH_AUTO_SETUPsettingGOOGLE_SEARCH_ENGINE_IDsettingTesting
GOOGLE_SEARCH_ENGINE_IDsetting e.g.GOOGLE_SEARCH_ENGINE_ID = 'b099996c09ebd4ece'SEARCH_AUTO_SETUP = Truesetting.GOOGLE_SEARCH_ENGINE_IDsetting.UI
GOOGLE_SEARCH_ENGINE_IDGOOGLE_SEARCH_ENGINE_ID