refactor(search): rebuild feature branch on main via cherry-pick - #1215
Merged
Conversation
So that it can be loaded from CDN. Use cases are: - if search template is broken - for custom search page - for non-Core website
Compared to "cms-search", "google-search" is: - more accurate - more obvious to those not familiar with Core-CMS
So dev sees 'google-search' from CSS before seeing it in HTML `id` attr.
Caused server error.
This had create dbreadcrumsb before.
Final markup undecided, so keep it simple, and easy to understand.
Added styles to fix link UI and UX.
Added styles to fix MORE link UI and UX.
- accompanies #1089 - mirrors TACC/tup-ui@eb93d55
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
wesleyboar
changed the base branch from
feat/template-and-setting-for-google-search
to
main
July 27, 2026 18:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Rebuilds the search feature on current
maininstead of stalerelease/v4.36.X.Warning
First run on a fresh database will crash
manage.py migrateitself, becauseapps/search_page/apps.py'sready()hook queriescms_pagebefore it exists. Workaround: setSEARCH_PAGE_AUTO_SETUP = False, migrate, then set it back toTrueand restart. Details.Important
Should instead:
Related
Changes
main+ cherry-picked search-only commitsTesting / UI
See #1129.