Skip to content

fix failing tests due to IPv4-mapped IPv6 rejection in Go 1.24.8 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnTitor merged 1 commit into from
May 17, 2026
Merged

fix failing tests due to IPv4-mapped IPv6 rejection in Go 1.24.8 #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
go: ['1.19.13', '1.20.10', '1.21.3']
go: ['1.24', '1.25', '1.26']

steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Based on the [wikipedia paper][wiki] and the [RFC 3986 document][rfc].

## Changelog

* **v1.1.2** : Fix test failures with Go 1.24.8+ due to stricter IPv6 host validation introduced by CVE-2025-47912.
* **v1.1.1** : Fix failing test due to Go1.12 changes (thanks to @ianlancetaylor).
* **2016-11-14 (v1.1.0)** : IDN: Conform to RFC 5895: Fold character width (thanks to @beeker1121).
* **2016-07-27 (v1.0.0)** : Normalize IDN to ASCII (thanks to @zenovich).
Expand Down
12 changes: 6 additions & 6 deletions purell_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,23 +271,23 @@ var (
},
{
"IPv6-2",
"http://[::ffff:192.168.1.1]/test",
"http://[2001:db8::1]/test",
FlagsSafe | FlagRemoveDotSegments,
"http://[::ffff:192.168.1.1]/test",
"http://[2001:db8::1]/test",
false,
},
{
"IPv6-3",
"http://[::ffff:192.168.1.1]:80/test",
"http://[2001:db8::1]:80/test",
FlagsSafe | FlagRemoveDotSegments,
"http://[::ffff:192.168.1.1]/test",
"http://[2001:db8::1]/test",
false,
},
{
"IPv6-4",
"htTps://[::fFff:192.168.1.1]:443/test",
"htTps://[2001:DB8::1]:443/test",
FlagsSafe | FlagRemoveDotSegments,
"https://[::ffff:192.168.1.1]/test",
"https://[2001:db8::1]/test",
false,
},
{
Expand Down
Loading