Repository navigation
fix failing tests due to IPv4-mapped IPv6 rejection in Go 1.24.8 - #42
Merged
Merged
Conversation
Maks1mS
pushed a commit
to stplr-dev/stplr
that referenced
this pull request
May 17, 2026
This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [github.com/PuerkitoBio/purell](https://github.com/PuerkitoBio/purell) | require | patch | `v1.2.1` → `v1.2.2` | [](https://securityscorecards.dev/viewer/?uri=github.com/PuerkitoBio/purell) | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/23) for more information. --- ### Release Notes <details> <summary>PuerkitoBio/purell (github.com/PuerkitoBio/purell)</summary> ### [`v1.2.2`](https://github.com/PuerkitoBio/purell/releases/tag/v1.2.2) [Compare Source](PuerkitoBio/purell@v1.2.1...v1.2.2) #### What's Changed - fix failing tests due to IPv4-mapped IPv6 rejection in Go 1.24.8 by [@​syedazeez337](https://github.com/syedazeez337) in [#​42](PuerkitoBio/purell#42) - chore: introduce zizmor by [@​JohnTitor](https://github.com/JohnTitor) in [#​43](PuerkitoBio/purell#43) - docs: update docs to reflect the latest info by [@​JohnTitor](https://github.com/JohnTitor) in [#​44](PuerkitoBio/purell#44) #### New Contributors - [@​syedazeez337](https://github.com/syedazeez337) made their first contribution in [#​42](PuerkitoBio/purell#42) **Full Changelog**: <PuerkitoBio/purell@v1.2.1...v1.2.2> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At 12:00 AM through 04:59 AM and 10:00 PM through 11:59 PM, Monday through Friday (`* 0-4,22-23 * * 1-5`) - Only on Sunday and Saturday (`* * * * 0,6`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNzAuMjIiLCJ1cGRhdGVkSW5WZXIiOiI0My4xNzAuMjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIktpbmQvRGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://altlinux.space/stapler/stplr/pulls/434
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41. Closes the Debian bug https://bugs.debian.org/1118422.
The three failing test cases used IPv4-mapped IPv6 addresses (
::ffff:192.168.1.1) which were rejected asinvalid IPv6 hostby Go 1.24.8. That release fixed CVE-2025-47912 by addingnetip.ParseAddrvalidation insideparseHost, but the initial implementation was too broad — it caught IPv4-mapped IPv6 alongside the actual CVE target (plain[192.168.1.1]).Go filed issue #75815 shortly after and the regression was fixed in Go 1.24.10. In Go 1.26.3 the check correctly uses
addr.Is4(), which isfalsefor::ffff:192.168.1.1(Is4In6()), so the original addresses pass again on current Go. But packages building against Go 1.24.8 or 1.24.9 hit the failure, which is what broke the Debian build.The fix replaces the three IPv4-mapped addresses with
2001:db8::1(RFC 3849 documentation range). The same normalization behaviours are covered — default port removal, scheme and host lowercasing — with no reliance on how Go handles this address class going forward.Also updates the CI matrix from the stale
1.19/1.20/1.21to1.24/1.25/1.26. The old matrix would never have caught this.Tested against Go 1.24.4, 1.24.8 (the broken version), and 1.26.3.