Skip to content

Fix Rare ConfigurationManager Crash #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinmine merged 2 commits into from
Aug 24, 2026
Merged

Fix Rare ConfigurationManager Crash #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3834e7
Pin ConfigurationManager
NCSGeek Aug 24, 2026
df9f83d
Add build check
NCSGeek Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,30 @@ jobs:
- name: Build solution
run: msbuild Celeste_Launcher.sln /nologo /nr:false /p:Version=$env:lastReleaseVersion /p:platform="Any CPU" /p:configuration="Release"

- name: Verify System.Configuration.ConfigurationManager DLL
run: |
$outputDir = $env:CELESTE_LAUNCHER_OUTPUT
$cfgDll = Join-Path $outputDir 'System.Configuration.ConfigurationManager.dll'

if (-not (Test-Path $cfgDll)) { throw "Missing System.Configuration.ConfigurationManager.dll in $outputDir" }

$actual = [System.Reflection.AssemblyName]::GetAssemblyName($cfgDll).FullName

$required = Get-ChildItem $outputDir -Filter *.dll | ForEach-Object {
try { ([System.Reflection.Assembly]::LoadFile($_.FullName)).GetReferencedAssemblies() }
catch { }
} | Where-Object { $_.Name -eq 'System.Configuration.ConfigurationManager' } |
Select-Object -ExpandProperty FullName -Unique

if (-not $required) {
return
}

$mismatch = $required | Where-Object { $_ -ne $actual }
if ($mismatch) {
throw "Assembly identity mismatch`n deployed: $actual`n required: $($mismatch -join ', ')"
}

- name: Build installer
uses: Minionguyjpro/Inno-Setup-Action@v1.2.7
with:
Expand Down
1 change: 1 addition & 0 deletions Celeste_Launcher_Gui/Celeste_Launcher_Gui.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@
<PackageReference Include="Markdig" Version="0.36.2" />
<PackageReference Include="Microsoft.Dism" Version="3.1.0" />
<PackageReference Include="Open.NAT.Core" Version="2.1.0.5" />
<PackageReference Include="System.Configuration.ConfigurationManager" Version="4.4.1" />
<PackageReference Include="System.IO.Compression" Version="4.3.0" />
<PackageReference Include="System.Net.Http" Version="4.3.4" />
<PackageReference Include="WindowsFirewallHelper" Version="2.2.0.86" />
Expand Down
1 change: 1 addition & 0 deletions Libs/Celeste_Public_Api/Celeste_Public_Api.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<PackageReference Include="Serilog.Settings.AppSettings" Version="2.2.2" />
<PackageReference Include="Serilog.Sinks.File" Version="5.0.0" />
<PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0" />
<PackageReference Include="System.Configuration.ConfigurationManager" Version="4.4.1" />
<PackageReference Include="System.Management" Version="8.0.0" />
<PackageReference Include="WebSocket4Net" Version="0.15.2" />
</ItemGroup>
Expand Down
Loading