Repository navigation
Fix Rare ConfigurationManager Crash - #123
Merged
Merged
Conversation
Pin System.Configuration.ConfigurationManager into the csproj as documented in dotnet/standard#506
Add a build yml check for ConfigurationManager issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an uncommon (yet observed) crash for some users related to a documented issue regarding ConfigurationManager's dll using guidance from that issue. (Pinning the ConfigurationManager DLL into the csproj)
This crash would happen for some users when GetLogFile tried to use ConfigurationManager to get the serilog path.
Also adds a build check to make sure the issue cannot regress by ensuring the DLL stays pinned and that the assembly matches.
Verified to fix the issue with a user who had the crash.