docs: document fit and transform on preprocessing transformers - #40
Conversation
|
Thanks for this — the parameter/return/raises coverage on these four methods is exactly the shape the rest of the codebase uses, and calling out that One correction before this goes in. Both
That isn't what the code does. The branch at if _get_pandas_output(self):
return X_df
return X_df.to_numpy()
Suggested wording:
Fix those two spots and I'll merge. Everything else in the PR is accurate as written. |
|
Fixed in b9f9b3d. Both |
b9f9b3d to
939c739
Compare
Closes #33.
Adds NumPy-style docstrings to
fitandtransformon:CRMCleanerFiscalYearTransformerWealthPercentileTransformerThe docstrings describe frozen state, return types, and raised errors.
WealthPercentileTransformerdocuments that percentiles are relative to the frozen training distribution inpercentile_lookup_.Verified:
MISSING: nonethenOKpytest --doctest-modules philanthropypasses (27)pytest tests/test_preprocessing.py tests/test_leakage.pypasses (49)