docs: backfill CHANGELOG and CONTRIBUTORS for #40, #42, #43, #44 - #45
Open
shivamlalakiya wants to merge 1 commit into
Open
docs: backfill CHANGELOG and CONTRIBUTORS for #40, #42, #43, #44#45shivamlalakiya wants to merge 1 commit into
shivamlalakiya wants to merge 1 commit into
Conversation
Four merged pull requests documented estimator methods and covered two transform-time guards, but none of them added the CHANGELOG entry and CONTRIBUTORS line that CONTRIBUTING.md requires. Backfill both rather than leave the work unlogged and the author unlisted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#40, #42, #43 and #44 are merged, but none of them added the
## [Unreleased]CHANGELOG entry or the CONTRIBUTORS.md line that CONTRIBUTING.md requires of every PR. This backfills both so the work is logged and the author is credited.What
Addedbullet for the two new transform-time guard tests (test: cover transform-time input guards #42), threeChangedbullets for the preprocessing docstrings (docs: document fit and transform on preprocessing transformers #40), the model-estimator docstrings (docs: document model estimator methods #44), and themake_donor_datasetdocstring (docs: add make_donor_dataset docstring #43).Docs only, no code touched.