Repository navigation
[19.0][MIG] helpdesk_mgmt_timesheet - #1129
Open
mcastillol14 wants to merge 2 commits into
Open
mcastillol14 wants to merge 2 commits into
mcastillol14 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative migration of
helpdesk_mgmt_timesheetto 19.0. There is an existing PR #1102 for this module, but it currently fails CI (test_helpdesk_portalreferencesself.env.ref("helpdesk_mgmt.helpdesk_team_2"), a demo-only xmlid that is not loaded by 19.0's test runner by default). This PR fixes that by creating the team in the test itself instead of relying on demo data. Opening as an alternative in case #1102 stays blocked; happy to close this one if #1102 gets fixed/merged first.