Repository navigation
Conversation
| [backendType, nodeId] | ||
| ) | ||
|
|
||
| if (backend.processStatus === 'stopped') { |
There was a problem hiding this comment.
Could we clear the modal state when the engine becomes stopped? This early return unmounts ModelHubModal and ConfirmModal but leaves openModelHubModal and modelPendingDelete set. If the engine starts again, the model hub—or a stale delete confirmation—could reappear. Consider resetting those states on stop and adding a stopped→running regression case.
| ) | ||
|
|
||
| if (backend.processStatus === 'stopped') { | ||
| return ( |
There was a problem hiding this comment.
This guard handles only the exact stopped status. While the engine is stopping, model rows and controls still render; for vLLM, modelOpsWhenStopped may also leave Load enabled because isRunning is false. Could we explicitly distinguish stopped from transitional states and disable actions while stopping, while preserving the intended actions for a fully stopped vLLM engine? A stopping-state regression test would clarify the expected behavior.
b45cccd to
3b138ac
Compare
Signed-off-by: nvrithik <rithikv@nvidia.com>
Signed-off-by: nvrithik <rithikv@nvidia.com>
3b138ac to
dcf06e2
Compare
Changelog title
Stopped engines show consistent model guidance
Changelog body
Bumps
Description
A stopped vLLM engine could show cached model rows and Add model, or “No model/weight files downloaded,” because model operations remain available in its disk cache. The Models section now follows reported engine status: stopped engines show only “Start engine to see models.” Running engines retain their existing model list and controls, including vLLM's on-but-idle state.
Follow-up to #181, based on its current head
2e300f2452baf581d341efaa898f48c428c4c997. This branch has one additional fix commit. Until #181 merges, GitHub's comparison against develop also includes that prerequisite.Scope
Changes the shared Models presentation for local and peer engine cards. Engine capabilities, cached inventory, runtime lifecycle and model actions keep their existing contracts. This PR is independent of the separate peer idle-timeout display fix.
Validation
npm run typecheck,npm run lint,npm run dead-code:check,npm run test:unit, andnpm run service-contracts:checkpassed in this isolated PR checkout.node scripts/spdx-headers.mjsandgit diff --checkpassed.Risk
Stopped engine cards intentionally hide model controls even when an engine's underlying cache operations are available while stopped. On-but-idle vLLM remains running and retains those controls. No persisted state, service binary, protocol or package-version file changes.
Checklist