Skip to content

Commit 3b138ac

Browse files
committed
fix(desktop): reset model dialogs and disable transitional controls
Signed-off-by: nvrithik <rithikv@nvidia.com>
1 parent c50d003 commit 3b138ac

8 files changed

Lines changed: 369 additions & 26 deletions

File tree

‎desktop/package-lock.json‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎desktop/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@
114114
"eslint-plugin-react-hooks": "^5.2.0",
115115
"eslint-plugin-react-refresh": "^0.4.19",
116116
"knip": "^6.4.1",
117+
"jsdom": "^29.1.1",
117118
"license-checker-rseidelsohn": "^4.4.2",
118119
"postcss": "^8.5.4",
119120
"prettier": "^3.5.3",

‎desktop/src/ui/components/ModelManager/ModelManager.tsx‎

Lines changed: 22 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
import { useCallback, useMemo, useState } from 'react'
4+
import { useCallback, useEffect, useMemo, useState } from 'react'
55
import { Button, Flex, Stack, Text } from '@nvidia/foundations-react-core'
66
import type { BackendInfo } from '@/ui/types/engine-info'
77
import { EngineCapabilities } from '@/ui/constants/engine-capabilities'
@@ -23,6 +23,16 @@ import type { ModelEntry } from '@/ui/types/model-hub'
2323
export function ModelManager({ backend, nodeId }: { backend: BackendInfo; nodeId: string }) {
2424
const [openModelHubModal, setOpenModelHubModal] = useState(false)
2525
const [modelPendingDelete, setModelPendingDelete] = useState<string | null>(null)
26+
const isRunning = backend.processStatus === 'running'
27+
28+
// A lifecycle transition ends the interaction that opened either dialog.
29+
// Forget it so restarting cannot reopen a stale download or delete prompt.
30+
useEffect(() => {
31+
if (!isRunning) {
32+
setOpenModelHubModal(false)
33+
setModelPendingDelete(null)
34+
}
35+
}, [isRunning])
2636
const models = (backend.models ?? []).sort((a, b) =>
2737
formatModelDisplayName(a.name, backend.type).localeCompare(
2838
formatModelDisplayName(b.name, backend.type)
@@ -115,6 +125,7 @@ export function ModelManager({ backend, nodeId }: { backend: BackendInfo; nodeId
115125

116126
const handleAction = useCallback(
117127
(modelName: string, action: string) => {
128+
if (!isRunning) return
118129
switch (action) {
119130
case 'load':
120131
window.pairApi.engines.loadModel(backendType, nodeId, modelName)
@@ -131,24 +142,25 @@ export function ModelManager({ backend, nodeId }: { backend: BackendInfo; nodeId
131142
break
132143
}
133144
},
134-
[backendType, confirmBeforeDelete, nodeId]
145+
[backendType, confirmBeforeDelete, isRunning, nodeId]
135146
)
136147

137148
// `ConfirmModal` closes (`onOpenChange(false)`) before it calls `onConfirm`,
138149
// which clears `modelPendingDelete`. This still reads the right model: the
139150
// callback closes over the value from the render that showed the modal, and
140151
// React's state update does not mutate that binding.
141152
const handleConfirmDelete = useCallback(() => {
142-
if (modelPendingDelete) {
153+
if (isRunning && modelPendingDelete) {
143154
window.pairApi.engines.deleteModel(backendType, nodeId, modelPendingDelete)
144155
}
145-
}, [backendType, modelPendingDelete, nodeId])
156+
}, [backendType, isRunning, modelPendingDelete, nodeId])
146157

147158
const handleExpiryChange = useCallback(
148159
(modelName: string, value: ModelExpiry) => {
160+
if (!isRunning) return
149161
window.pairApi.engines.setModelExpiry(backendType, nodeId, modelName, value)
150162
},
151-
[backendType, nodeId]
163+
[backendType, isRunning, nodeId]
152164
)
153165

154166
const transientPullProgress = transientModel
@@ -159,15 +171,14 @@ export function ModelManager({ backend, nodeId }: { backend: BackendInfo; nodeId
159171
() => caps?.hasModelSearchOnlyWhenRunning ?? false,
160172
[caps?.hasModelSearchOnlyWhenRunning]
161173
)
162-
const isRunning = useMemo(() => backend.processStatus === 'running', [backend.processStatus])
163174
const supportsSearch = useMemo(
164175
() => (caps?.hasPullModel ?? false) && (!hasModelSearchOnlyWhenRunning || isRunning),
165176
[caps?.hasPullModel, hasModelSearchOnlyWhenRunning, isRunning]
166177
)
167178

168179
const handleDownload = useCallback(
169180
(entries: ModelEntry[]) => {
170-
if (!entries || entries.length === 0) return
181+
if (!isRunning || !entries || entries.length === 0) return
171182

172183
setOpenModelHubModal(false)
173184

@@ -177,7 +188,7 @@ export function ModelManager({ backend, nodeId }: { backend: BackendInfo; nodeId
177188
}
178189
}
179190
},
180-
[backendType, nodeId]
191+
[backendType, isRunning, nodeId]
181192
)
182193

183194
if (backend.processStatus === 'stopped') {
@@ -232,7 +243,7 @@ export function ModelManager({ backend, nodeId }: { backend: BackendInfo; nodeId
232243
)}
233244

234245
<ConfirmModal
235-
open={modelPendingDelete !== null}
246+
open={isRunning && modelPendingDelete !== null}
236247
onOpenChange={open => {
237248
if (!open) setModelPendingDelete(null)
238249
}}
@@ -249,12 +260,13 @@ export function ModelManager({ backend, nodeId }: { backend: BackendInfo; nodeId
249260
size="small"
250261
kind="primary"
251262
color="brand"
263+
disabled={!isRunning}
252264
onClick={() => setOpenModelHubModal(true)}
253265
>
254266
Add model
255267
</Button>
256268
<ModelHubModal
257-
engine={openModelHubModal ? backend.type : null}
269+
engine={isRunning && openModelHubModal ? backend.type : null}
258270
onOpenChange={setOpenModelHubModal}
259271
onSubmit={handleDownload}
260272
downloadedModels={models}

‎desktop/src/ui/components/ModelManager/ModelRow.tsx‎

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,11 @@ function ModelRowInner({
4545
const items: { id: string; children: string; disabled?: boolean; danger?: boolean }[] = []
4646
// A command is already in flight for this model -- lock the whole menu so
4747
// the user cannot fire a second conflicting op before it resolves.
48-
const busy = pendingAction !== undefined
48+
const busy = !isRunning || pendingAction !== undefined
4949
items.push({
5050
id: 'load',
5151
children: 'Load',
52-
disabled:
53-
busy ||
54-
isLoaded ||
55-
!model.downloaded ||
56-
(!isRunning && !capabilities.modelOpsWhenStopped)
52+
disabled: busy || isLoaded || !model.downloaded
5753
})
5854
if (capabilities.hasEject) {
5955
items.push({
@@ -79,7 +75,6 @@ function ModelRowInner({
7975
capabilities.hasEject,
8076
capabilities.hasDeleteModel,
8177
capabilities.deleteBlockedWhileLoaded,
82-
capabilities.modelOpsWhenStopped,
8378
isLoaded,
8479
isRunning,
8580
model.downloaded,
@@ -99,6 +94,7 @@ function ModelRowInner({
9994
modelName={model.name}
10095
formattedName={formattedName}
10196
isLoaded={isLoaded}
97+
disabled={!isRunning}
10298
actionItems={actionItems}
10399
actionDd={actionDd}
104100
onAction={onAction}
@@ -108,6 +104,7 @@ function ModelRowInner({
108104
progress={progress}
109105
busyLabel={busyLabel}
110106
hasExpiry={capabilities.hasExpiry}
107+
disabled={!isRunning}
111108
expiryDd={expiryDd}
112109
onExpiryChange={onExpiryChange}
113110
/>

‎desktop/src/ui/components/ModelManager/ModelRowHeader.tsx‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,15 @@ export function ModelRowHeader({
1111
modelName,
1212
formattedName,
1313
isLoaded,
14+
disabled,
1415
actionItems,
1516
actionDd,
1617
onAction
1718
}: {
1819
modelName: string
1920
formattedName: string
2021
isLoaded: boolean
22+
disabled: boolean
2123
actionItems: { id: string; children: string; disabled?: boolean; danger?: boolean }[]
2224
actionDd: ModelRowDropdownControl
2325
onAction: (modelName: string, action: string) => void
@@ -26,11 +28,11 @@ export function ModelRowHeader({
2628
() =>
2729
actionItems.map(item => ({
2830
children: item.children,
29-
disabled: item.disabled,
31+
disabled: disabled || item.disabled,
3032
danger: item.danger,
3133
onSelect: () => onAction(modelName, item.id)
3234
})),
33-
[actionItems, modelName, onAction]
35+
[actionItems, disabled, modelName, onAction]
3436
)
3537

3638
return (
@@ -53,6 +55,7 @@ export function ModelRowHeader({
5355
{actionItems.length > 0 && (
5456
<Dropdown
5557
items={dropdownItems}
58+
disabled={disabled}
5659
showChevron={false}
5760
size="small"
5861
className="compact-dropdown shrink-0"

‎desktop/src/ui/components/ModelManager/ModelRowSecondaryRow.tsx‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ export function ModelRowSecondaryRow({
1717
progress,
1818
busyLabel,
1919
hasExpiry,
20+
disabled,
2021
expiryDd,
2122
onExpiryChange
2223
}: {
@@ -25,18 +26,20 @@ export function ModelRowSecondaryRow({
2526
/** Optimistic "working" label (load/eject/delete in flight) shown with a spinner. */
2627
busyLabel?: string | null
2728
hasExpiry: boolean
29+
disabled: boolean
2830
expiryDd: ModelRowDropdownControl
2931
onExpiryChange: (modelName: string, value: ModelExpiry) => void
3032
}) {
3133
const expiryItems: DropdownEntry[] = useMemo(
3234
() =>
3335
EXPIRY_OPTIONS.map(item => ({
3436
children: item.children,
37+
disabled,
3538
onSelect: () => {
3639
if (isModelExpiry(item.id)) onExpiryChange(model.name, item.id)
3740
}
3841
})),
39-
[model.name, onExpiryChange]
42+
[disabled, model.name, onExpiryChange]
4043
)
4144

4245
return (
@@ -83,6 +86,7 @@ export function ModelRowSecondaryRow({
8386
{hasExpiry && (
8487
<Dropdown
8588
items={expiryItems}
89+
disabled={disabled}
8690
size="small"
8791
className="compact-dropdown"
8892
onOpenChange={expiryDd.onOpenChange}

0 commit comments

Comments
 (0)