Repository navigation
fix(core): a hovered link on the alternate screen keeps its colour (#163) - #165
Merged
Merged
Conversation
) xterm's DOM renderer underlines a hovered link by replacing the row's contents, with no onRender, so the ink was wiped until a scroll redrew the rows. A MutationObserver inks any replaced row that holds no ink. The e2e hovers and leaves a link on the alternate screen (failed before the fix). Core 0.28.3, app 0.35.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
This was referenced Oct 10, 2026
Closed
) The MutationObserver re-inked every replaced alternate-screen row holding no ink, so each row onRender had just scanned was scanned again, and it stayed attached on the normal screen. It now re-inks only a row that held ink and holds none (rowsToReink, unit tested), and disconnects when leaving the alternate screen; the first onRender there attaches it again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 11, 2026
) (#165) * fix(core): a hovered link on the alternate screen keeps its colour (#163) xterm's DOM renderer underlines a hovered link by replacing the row's contents, with no onRender, so the ink was wiped until a scroll redrew the rows. A MutationObserver inks any replaced row that holds no ink. The e2e hovers and leaves a link on the alternate screen (failed before the fix). Core 0.28.3, app 0.35.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t * perf(core): the link-ink row watch re-inks only rows that lost ink (#163) The MutationObserver re-inked every replaced alternate-screen row holding no ink, so each row onRender had just scanned was scanned again, and it stayed attached on the normal screen. It now re-inks only a row that held ink and holds none (rowsToReink, unit tested), and disconnects when leaving the alternate screen; the first onRender there attaches it again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163.
The owner's recording (2026-10-10): in Claude Code's fullscreen view, a link that is hovered turns white and stays white after the pointer leaves, until a scroll.
Cause (measured): Prism Terminal, not Claude Code.
termLinkPaint), which wraps the link text in a span each time xterm draws a row (onRender)._setCellUnderline,DomRenderer.ts:525). That fires noonRender, so the ink was wiped.Fix: a MutationObserver on the rows inks any replaced row that holds no ink. Inking is itself a mutation, but the row then holds ink and is left alone, so it cannot loop. This is a core change, so Prism gets it too. Core 0.28.3, app 0.35.3.
Gates:
links: the new checks hover a link on the alternate screen and leave it, with no scroll. They failed before the fix (2 fails) and pass after (10/0).settingsLook(8), which fails on main too (an "only accent button" check older than feat(core): an on switch wears the theme's accent (#138) #139's accent switches) and is fixed in feat: see-through window, theme order and Most recent tab switching (#156, #157, #158) #161.🤖 Generated with Claude Code
https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t