Skip to content

fix(security-audit): remove CodeQL from the autonomous pipeline — it is too slow to gate PRs - #589

Merged
unohee merged 1 commit into
mainfrom
swarm/AGT-4160-fix-security-audit-remove-codeql-from-th
Sep 9, 2026
Merged

unohee merged 1 commit into
mainfrom
swarm/AGT-4160-fix-security-audit-remove-codeql-from-th

Conversation

@unohee

@unohee unohee commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

문제 — 자율 파이프라인이 워커 편집마다 CodeQL을 돌리고, 언어마다 최대 20분을 기다리거나 security-audit-infra로 세운다. PR이 안 나간다.

원인 — securityAudit.enabled 기본 true. vela config에 키 없음.

해결 — CodeQL 게이트를 자율 파이프라인 기본 경로에서 제거. enabled 기본 false. vela는 즉시 비활성 + 재시작.

검증 — 파이프라인이 runSecurityAudit/게이트를 호출하지 않음. vela 로그에 CodeQL database create 없음. 워커가 PR 경로로 진행.

⚠️ File overlap with in-flight work

This branch changes files that other open PRs / active branches also touch. Coordinate before merging to avoid divergent parallel edits (INT-2388 #3):

Linear

Closes AGT-4160


🤖 Generated with OpenSwarm

@unohee

unohee commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator Author

🔍 Fresh review of 12c18e2 (openswarm pr review --fresh)

✓ Decision: APPROVE
CodeQL 게이트를 opt-in으로 전환(securityAudit.enabled, 기본 OFF). package-lock.json libc 필드 제거는 무해한 lockfile 정규화. 두 변경 모두 정확하고 회귀 위험 낮음.
Suggestions:
- 향후 securityAudit.enabled=false 경로의 단위 테스트 추가를 검토하세요(현재 커버리지 gap이나 기능 위험은 낮음).

@unohee
unohee merged commit 89ad4b4 into main Sep 9, 2026
8 checks passed
@unohee
unohee deleted the swarm/AGT-4160-fix-security-audit-remove-codeql-from-th branch September 9, 2026 23:44
unohee added a commit that referenced this pull request Sep 10, 2026
…597)

AGT-4160 (#589) took CodeQL out of the autonomous pipeline and was right to.
A whole-database scan per worker edit costs up to 20 minutes per language and
parked runs as `security-audit-infra`, so pull requests stopped coming out —
a security control paid for with the throughput of the thing it protects.

What it left behind was nothing. `review-gate.yml` only *uploads* SARIF from
`openswarm review` — `codeql-action/upload-sarif` is the ingestion endpoint,
not the scanner — and the only `codeql database` invocation in the tree sits
behind `securityAudit.enabled` in `pairPipeline.ts`, which now defaults off.
After that merge this repository was analysed by nothing.

A capability that quietly stops running is precisely the failure this
repository spent today removing from three other gates: a CI install that
silently skipped, a reviewer that saw 22% of publications, a deleted-test
check that returned "nothing found" when it could not compare.

Weekly, on `v*` tags, and on demand. Those are the points where 20 minutes is
affordable and a finding is still actionable before it reaches users.
`security-extended` rather than the default suite, because the default is
tuned for near-zero false positives on any repository and this one is an agent
runtime that spawns processes and writes files under a model's instructions.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant