Repository navigation
ci: run CodeQL weekly and on release tags, not on every worker edit - #597
Merged
Merged
Conversation
AGT-4160 (#589) took CodeQL out of the autonomous pipeline and was right to. A whole-database scan per worker edit costs up to 20 minutes per language and parked runs as `security-audit-infra`, so pull requests stopped coming out — a security control paid for with the throughput of the thing it protects. What it left behind was nothing. `review-gate.yml` only *uploads* SARIF from `openswarm review` — `codeql-action/upload-sarif` is the ingestion endpoint, not the scanner — and the only `codeql database` invocation in the tree sits behind `securityAudit.enabled` in `pairPipeline.ts`, which now defaults off. After that merge this repository was analysed by nothing. A capability that quietly stops running is precisely the failure this repository spent today removing from three other gates: a CI install that silently skipped, a reviewer that saw 22% of publications, a deleted-test check that returned "nothing found" when it could not compare. Weekly, on `v*` tags, and on demand. Those are the points where 20 minutes is affordable and a finding is still actionable before it reaches users. `security-extended` rather than the default suite, because the default is tuned for near-zero false positives on any repository and this one is an agent runtime that spawns processes and writes files under a model's instructions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#589 (AGT-4160) removed CodeQL from the autonomous pipeline. That was correct — a whole-database scan per worker edit costs up to 20 minutes per language and parked runs as
security-audit-infra, so pull requests stopped coming out. A security control paid for with the throughput of the thing it protects is not a good trade.But it left the analysis running nowhere. I checked before merging:
.github/contains nocodeql-action/initoranalyzestep.review-gate.ymlusescodeql-action/upload-sarif, which is the ingestion endpoint for any SARIF — it publishesopenswarm review's findings, it does not scan.codeql databaseinvocation in the tree issrc/verify/securityAudit.ts, reached frompairPipeline.ts:178behindsecurityAudit?.enabled— now defaulting to false.So after #589 this repository is analysed by nothing.
What this adds
CodeQL on a weekly schedule, on
v*tags, and on demand — the points where 20 minutes is affordable and a finding is still actionable before it reaches users. Not per edit, and not never.security-extendedrather than the default suite: the default is tuned to keep false positives near zero on any repository, and this one is an agent runtime that spawns processes and writes files under a model's instructions.The cron is
17 4 * * 1rather than0 4— every repository that asks for "weekly" lands on:00, and the shared runner pool feels it.The pattern
A capability that quietly stops running is the failure this repository spent today removing from three other gates: a CI install that silently skipped (#588), a reviewer that saw 22% of publications (#592), and a deleted-test check that returned "nothing found" when it could not compare (#592). Turning CodeQL off without putting it anywhere would have been the fourth.
🤖 Generated with Claude Code