Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the selected normal ball-filter parameter candidate to improve tracking without adding an experimental estimator. This changes 12 settings in
etc/parameters/base/ball_filter.json5, including measurement/process noise, confidence decay, association uncertainty, and guarded publication blending.This PR builds on the current production implementation from #2944 (
25c89eeac). Relative to #2944, the only change is the parameter file; the diff against main currently also includes #2944's existing production changes. After #2944 merges, this can be rebased to become a parameters-only PR. No simulator, optimizer, PDA, IMM, or other experimental branch changes are added here.For local simulator/Twix evaluation, use the separate branch
schluis:dev/ball-filter-preferred-simulator-20261004. Itsdocs/workflow/ball-filter-lab.mdcontains the zero-trial preview commands, which retain these exact values.Validation:
cargo +1.98.1 test --locked -p ball_filter --lib).simulate,twix, andball-filter-tuner; 39 tuner tests, the simulator CLI test, and both GUI CLI help checks pass. Three outdated tests were adapted to explicit parameter configuration only on that tooling branch.diagnostic-pda-common-01candidate after f32 parsing.Kept as a draft for local evaluation: development false-track time increases by 0.160 seconds and two development recordings fail guards against the updated starting configuration. Four recordings fail guards against old main. The reserved final evaluation has not run; these are historical simulator results, not robot/game validation. No further tuning is running.
Fast-shot validation is still in progress. A controlled 6 m/s sequence exposes repeated primary-hypothesis spawning with both these parameters and the updated PR #2944 defaults. Globally increasing the association gate fixes that sequence but regresses other recordings, so no such change is included here.
The simulator companion branch now includes velocity-aware optimizer scoring (
single_ball_position_velocity_v9, commitb1ed59840), with overall/close-range velocity RMSE shown in Twix and regression guards for velocity accuracy and availability. New tuning is being evaluated separately; earlier v8 loss values are not comparable to v9 losses. The parameter payload of this draft PR remains the original preferred candidate pending those results.