Conversation
knoellle
enabled auto-merge
July 22, 2025 07:11
paudar
self-requested a review
November 1, 2025 11:39
paudar
reviewed
Nov 1, 2025
| } | ||
| } | ||
|
|
||
| pub fn get_spl_messages<'a>( |
Contributor
There was a problem hiding this comment.
Is it worth it to reimplement the get_spl_messages function in this crate?
Contributor
|
is reimplemented in #2723 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? What?
The ball search heat map is quite a mess.
Among other things, it was completely missing handling for kick in.
This PR adds such handling, by projecting the heat to the sidelines. The heat is projected to the left/right side-line proportionally depending on the cell's position.
Fixes #
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
How to Test
Look at the ball search heat map map overlay in twix during the
kick_inbevyhavior scenario.