Skip to content

Pin the low-H cold-start P_surf by the IW buffer of CALLIOPE #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timlichtenberg merged 5 commits into from
Nov 8, 2026
Merged

Pin the low-H cold-start P_surf by the IW buffer of CALLIOPE #1075

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e01851
Pin the low-H cold-start P_surf by the IW buffer of the installed CAL…
timlichtenberg Nov 8, 2026
94618bb
Drop the pin test assertion that compares the pins with themselves
timlichtenberg Nov 8, 2026
4e5c87b
Tie the low-H buffer separation check to the pin tolerance
timlichtenberg Nov 8, 2026
de1a9a3
Name the CALLIOPE versions of the low-H pins and call oneill a buffer…
timlichtenberg Nov 8, 2026
9c1f713
Run the PR checks again
timlichtenberg Nov 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion tests/outgas/test_calliope_cold_start_smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,18 @@

pytestmark = [pytest.mark.smoke, pytest.mark.timeout(60)]

# P_surf [bar] of the seeded low-H cold start per IW buffer of the installed CALLIOPE:
# Fischer in CALLIOPE 26.10.5, Hirschmann (2021) on CALLIOPE main.
_LOW_H_P_SURF = {'fischer': 24.8673, 'hirschmann': 25.0959}
_LOW_H_REL = 1e-4


def _low_h_p_surf(model):
"""The pinned P_surf of the IW buffer ``model``; a buffer without a pin fails by name."""
if model not in _LOW_H_P_SURF:
pytest.fail(f'no pinned low-H P_surf for the IW buffer {model!r}')
return _LOW_H_P_SURF[model]


def _cold_start(caller_seed, config=None):
hf_row = _surface_pressure_hf_row()
Expand Down Expand Up @@ -102,8 +114,18 @@ def test_seeded_low_h_cold_start_returns_the_physical_root(tmp_path):
calc_surface_pressures({'output': str(tmp_path)}, config, hf_row)
assert hf_row['H2O_bar'] > 0.0
assert hf_row['H2_bar'] > 0.0
assert hf_row['P_surf'] == pytest.approx(24.8673, rel=1e-4)
from calliope.oxygen_fugacity import DEFAULT_FO2_MODEL

assert hf_row['P_surf'] == pytest.approx(_low_h_p_surf(DEFAULT_FO2_MODEL), rel=_LOW_H_REL)
gate = max(budgets.values()) * config.outgas.solver_rtol + config.outgas.mass_thresh
for e, m in budgets.items():
held = sum(hf_row[f'{e}_kg_{r}'] for r in ('atm', 'liquid', 'solid'))
assert abs(held - m) <= gate, e


def test_low_h_pin_follows_the_iw_buffer_and_names_a_buffer_without_a_pin():
"""The pin tolerance tells the IW buffers apart (0.9 % apart); a buffer without a pin fails."""
fischer, hirschmann = _low_h_p_surf('fischer'), _low_h_p_surf('hirschmann')
assert hirschmann != pytest.approx(fischer, rel=_LOW_H_REL)
with pytest.raises(pytest.fail.Exception, match="IW buffer 'oneill'"):
_low_h_p_surf('oneill')
Loading