Repository navigation
Pin the low-H cold-start P_surf by the IW buffer of CALLIOPE - #1075
Merged
Merged
Conversation
…LIOPE The seeded low-H cold start gives P_surf 24.8673 bar with the Fischer IW buffer of CALLIOPE 26.10.5 and 25.0959 bar with the Hirschmann (2021) buffer that CALLIOPE main makes the default; the test reads calliope.oxygen_fugacity.DEFAULT_FO2_MODEL and fails by name for a buffer without a pin.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 148 148
Lines 24928 24928
Branches 4171 4171
=======================================
Hits 23638 23638
Misses 861 861
Partials 429 429
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
6 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_seeded_low_h_cold_start_returns_the_physical_rootpins the surface pressure of a seeded low-H cold start at 24.8673 bar. That value holds for the Fischer IW buffer, the default of the released CALLIOPE 26.10.5. CALLIOPE main uses the Hirschmann (2021) buffer by default, and there the same cold start gives 25.0959 bar, so the test fails once PROTEUS runs against the next CALLIOPE release.The test now reads
calliope.oxygen_fugacity.DEFAULT_FO2_MODELof the installed CALLIOPE and expects the pin of that buffer (relative tolerance 1e-4, as before). A buffer without a pin fails the test by name. A second test checks that the tolerance tells the 2 pins apart; they differ by 0.92 % (25.0959 / 24.8673 - 1). PROTEUS has no config key that selects the IW buffer on the CALLIOPE path, so the default of the installed CALLIOPE is the buffer the cold start uses.Tests only; no source change. This lets PROTEUS main pass with both CALLIOPE 26.10.5 and the next CALLIOPE release, which includes FormingWorlds/CALLIOPE#47.
No related issue.
Validation of changes
fwl_calliope-26.10.5installed and both tests of this file passed on macOS and Ubuntu: https://github.com/FormingWorlds/PROTEUS/actions/runs/42447222675. The last commit (de1a9a3) changes only a comment and the name and docstring of the second test.pytest tests/outgas/test_calliope_cold_start_smoke.pygives 5 passed at de1a9a3. The version of this file on main gives 1 failed and 3 passed against the same CALLIOPE.oneill, which has no pin; the test then fails and names the buffer.Lines by category (
pr-breakdown 9b8e860 de1a9a3):Checklist