Implement cwltool:Loop extension for CWL runner (#4227)#5542
Merged
Conversation
…all accumulation, and full LoopInput feature support (multi-source, default, valueFrom) with tests.
…workflow-loop-extension
adamnovak
requested changes
Jun 26, 2026
adamnovak
left a comment
Member
There was a problem hiding this comment.
This looks pretty good, but I think it could be simplified.
We should be able to pull most of the test files from the packaged data files of our cwltool dependency.
And I think we can get away with not adding either LoopOutputSource (because Toil promises can already do a dict key lookup) or LoopStepValueFrom (because StepValueFrom can be generalized to cover both cases by adding an optional parameter and a conditional).
Instance of LoopOutputSource was replaced with JustAValue which holds a promise for the key we need. StepValueFrom was updated to include LoopStepValueFrom's functionality.
…types and assertions
…side when/outputMethod
…uirement validation for loop valueFrom
…ackticks, add validation comments in CWLLoop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Implement
cwltool:Loopextension for Toil's CWL runner, adding iterative loop execution,outputMethod: allaccumulation, and fullLoopInputfeature support (loopSource,linkMerge,pickValue,default,valueFrom) with a configurable iteration limit via--cwl-loop-iteration-limit.Resolves #4227
Reviewer Checklist
issues/XXXX-fix-the-thingin the Toil repo, or from an external repo.camelCasethat want to be insnake_case.docs/running/{cliOptions,cwl,wdl}.rstMerger Checklist