Keep document chrome out of captured layout boundaries - #1780
Merged
Merged
Conversation
4 of 5 tasks
…ndaries Deep media layout capture is for a content region. An ancestor that also owns header or footer landmarks must convert children so those landmarks stay native blocks.
chubes4
force-pushed
the
fix/layout-boundary-excludes-chrome
branch
from
September 16, 2026 13:43
864c1f1 to
4cb498c
Compare
Site-shell detection is for wrappers around header/main, not a main that contains a page-local header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A deep wrapper around header + main + media was captured as one
custom/responsive-layoutblock, so the whole page stopped being editable. That fired once Tiny Menu stopped counting as a runtime island and the wrapper no longer had a runtime target in-subtree.Decline layout-boundary capture when the element contains header/footer (or banner/contentinfo) landmarks. A deep
mainthat is only media still compiles as a typed layout boundary.Stacked on #1763 so a Wix Tiny Menu can become
core/navigationafter the shell stays in the block tree.Proven on https://www.rachelbraundesign.com/ homepage HTML: 197 blocks / 13 navigation / 0 whole-page layout capture (was 1 opaque layout after #1763).
Test plan
php tests/unit/layout-boundary-excludes-shell.phpphp tests/unit/overlay-hidden-navigation.phpphp tests/contract/staged-artifact-compilation.phpAI assistance
Grok 4.6 via OpenCode diagnosed the Rachel Braun re-import collapsing to one
custom/responsive-layoutafter overlay-nav conversion, implemented the shell-landmark guard, added the unit test, and ran the listed php-transformer checks. Chris Huber remains responsible for review and merge.