Keep converting nav when overlay chrome is a runtime target - #1789
Merged
Merged
Conversation
…ntime target An empty overlay pane marked as a runtime DOM target aborted list-backed navigation before the hidden link list could become core/navigation.
…is a runtime target After the hidden list is already the menu, a runtime-targeted hamburger must be skipped as chrome instead of aborting conversion.
chubes4
force-pushed
the
fix/nav-skip-runtime-overlay
branch
from
September 16, 2026 13:43
5d438f4 to
03bac8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSI compile injects runtime DOM selectors from captured scripts. An empty overlay pane (
fullScreenOverlay) is both navigation chrome and a runtime target, which aborted list-backed conversion (return []) before the hidden Tiny Menu links could becomecore/navigation.Skip that abort for overlay/fullscreen/drawer panes that contain no links. The hidden list still becomes a native mobile overlay menu.
Stacked on #1780. Proven against a Wix Tiny Menu fixture with
runtime_dom_selectors: ['.fullScreenOverlay'].Test plan
php tests/unit/overlay-hidden-navigation.php(includes the runtime-selector case)php tests/unit/layout-boundary-excludes-shell.phpphp tests/unit/navigation-inert-support-children.phpphp tests/contract/run.phpcore/navigationwith overlayMenu mobileAI assistance
Grok 4.6 via OpenCode diagnosed why HtmlTransformer emitted navigation but SSI compilePage dropped it (runtime overlay selector abort), implemented the skip, extended the unit test, and ran the listed checks. Chris Huber remains responsible for review and merge.