Repository navigation
Refactor to streaming BinaryPackage/XmlPackage parsers (#33) - #34
Merged
Merged
Conversation
Replace the inverted container-as-package layer with the intended four-group model: BinaryPackage + BinaryPackageParser and XmlPackage + XmlPackageParser stream semantic units; readers consume those streams to build DataSet. CSV stays on CsvReader. Co-authored-by: Fan Feilong <fanfeilong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33
Intent
The previous package/parser layer treated the file container as the package and batch-loaded a
DataSet. The intended design is:BinaryPackage(BIFF record)BinaryPackageParserXmlPackage(row/cell/merge/hyperlink/…)XmlPackageParserParsers stream-parse and stream-emit packages; readers consume those streams.
Changes
IExcelPackage/StreamPackage/ExcelPackageParserFactory/ batch*PackageParser.Parse→DataSetIPackageParser<T>,BinaryPackage+BinaryPackageParser,XmlPackagehierarchy +XmlPackageParserExcelBinaryReader/ExcelOpenXmlReaderconsume package streams;ZipWorkeris IO only againCsvReader(outside binary/xml symmetry)Verify
src/test.sh— all casesDone!(exit 0)