Repository navigation
fix: explicit panic on empty Selector - #179
Merged
Merged
Conversation
Owner
|
Thanks! These changes look sensible to me. Sorry I'd not got to this faster: I've a lot of commitments right now and no longer have much time for this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176.
An empty
Selectoris causing a panic in 0.12.0 with theeventual-fairnessfeature, due to the new RNG not accepting an empty range. Without theeventual-fairnessfeature, it maintains the old behaviour;wait()blocks forever and the timeout/deadline functions wait their full timeout.I have fixed the
eventual-fairnesspanic, and added an explicit panic ifwait()is called on an emptySelectorsince this would otherwise block forever. I've also documented the (existing) behaviour ofwait_timeoutandwait_deadlinewith an emptySelector.