tvos: Add platform DRM key system registration - #12482
Open
abhijeetk wants to merge 1 commit into
Open
Conversation
Contributor
|
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for platform DRM key system info on iOS internal builds by updating the BUILD.gn dependencies and registering the key system in cobalt_content_renderer_client.cc. The review feedback suggests nesting the new dependency check inside the existing use_starboard_media block in BUILD.gn to avoid duplication and improve maintainability.
Register the platform DRM key system (com.youtube.<platform-drm>) in
the Cobalt content renderer client with encryption scheme support.
Without this registration, YouTube JS's call to
navigator.requestMediaKeySystemAccess("com.youtube.<platform-drm>", config)
fails with NotSupportedError because no KeySystemInfo exists for this
key system. Blink's KeySystemConfigSelector checks each requested
initDataType against the registered
KeySystemInfo::IsSupportedInitDataType(). The PlatformDrmKeySystemInfo
advertises W3C EME init data types (cenc, webm) that match what YouTube
negotiates, allowing the capability check to pass and enabling MediaKeys
creation for Platform DRM.
Supported by internal build only.
Bug: 501343649
Bug: 498421484
abhijeetk
force-pushed
the
drm-key-registration
branch
from
September 6, 2026 18:30
dd88fe0 to
e85b975
Compare
Collaborator
Author
Collaborator
Author
|
These changes initially was part of existing PR : #11141, now its rebased. We can land it separatelly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register the platform DRM key system in the Cobalt content renderer
client for internal tvOS builds.
This registration is required to prevent NotSupportedError when
the YouTube application calls
requestMediaKeySystemAccess. Byproviding the platform-specific KeySystemInfo, the renderer can
successfully advertise supported initialization data types and
encryption schemes, enabling the creation of MediaKeys for the
platform DRM.
Supported by internal build only.
Bug: 501343649
Bug: 498421484