You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Disable the media remoting and media remoting RPC build flags in the
common configuration. Cobalt does not use these features, which
include Casting and Remoter Mojo endpoints. Disabling them can
reduce libchrobalt.so size and eliminate runtime memory overhead
of unused mojo EndpointClient.
build: Disable Media Remoting
Disable the media remoting and media remoting RPC build flags in the
common configuration. Cobalt does not support these features, which
include Casting and Remoter Mojo endpoints. This change helps keep the
media stack clean of unused components.
Bug: 557781504
💡 Pro Tips for a Better Commit Message:
Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
Re-run the Generator: Post a comment with: /generate-commit-message
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request disables Media Remoting (Casting and Remoter Mojo endpoints) for Cobalt by setting enable_media_remoting and enable_media_remoting_rpc to false in the common build configuration file (cobalt/build/configs/common.gn). There are no review comments, and I have no feedback to provide.
The reason will be displayed to describe this comment to others. Learn more.
Probably put this at the end of this file as these are newly added. And how many it saves should be in the comment as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable the media remoting and media remoting RPC build flags in the
common configuration. Cobalt does not use these features, which
include Casting and Remoter Mojo endpoints. Disabling them can
reduce libchrobalt.so size and eliminate runtime memory overhead
of unused mojo EndpointClient.
Bug: 557781504