Skip to content

cobalt: Disable Media Remoting - #12477

Open
jasonzhangxx wants to merge 1 commit into
youtube:mainfrom
jasonzhangxx:disable-media-remoting
Open

cobalt: Disable Media Remoting#12477
jasonzhangxx wants to merge 1 commit into
youtube:mainfrom
jasonzhangxx:disable-media-remoting

Conversation

@jasonzhangxx

@jasonzhangxx jasonzhangxx commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Disable the media remoting and media remoting RPC build flags in the
common configuration. Cobalt does not use these features, which
include Casting and Remoter Mojo endpoints. Disabling them can
reduce libchrobalt.so size and eliminate runtime memory overhead
of unused mojo EndpointClient.

Bug: 557781504

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


build: Disable Media Remoting

Disable the media remoting and media remoting RPC build flags in the
common configuration. Cobalt does not support these features, which
include Casting and Remoter Mojo endpoints. This change helps keep the
media stack clean of unused components.

Bug: 557781504

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor
Context State Description
CI / android ✅ PASS Passed
CI / aosp ✅ PASS Passed
CI / evergreen ✅ PASS Passed
CI / linux ✅ PASS Passed
CI / tvos ✅ PASS Passed
import/copybara ✅ PASS Change imported to Gerrit
kokoro ✅ PASS Kokoro build finished

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor
Context State Description
CI / evergreen ⏳ PENDING Checks are running
CI / tvos ⏳ PENDING Checks are running

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables Media Remoting (Casting and Remoter Mojo endpoints) for Cobalt by setting enable_media_remoting and enable_media_remoting_rpc to false in the common build configuration file (cobalt/build/configs/common.gn). There are no review comments, and I have no feedback to provide.

@jasonzhangxx
jasonzhangxx requested review from a team, borongc, osagie98 and sherryzy and removed request for borongc and osagie98 September 6, 2026 04:02
@borongc

borongc commented Sep 7, 2026

Copy link
Copy Markdown
Member

Disabling them can reduce libchrobalt.so size and eliminate runtime memory overhead of unused mojo EndpointClient.

Do you have numbers? It is required to put the saving MB in the PR description if it can save the binary size.

# Cobalt doesn't use //third_party/ffmpeg.
media_use_ffmpeg = false

# Disable Media Remoting (Casting / Remoter Mojo endpoints) for Cobalt.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably put this at the end of this file as these are newly added. And how many it saves should be in the comment as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants