[Cobalt] Add URL sanitization for URLs provided by the platform. - #12470
Open
jshorta wants to merge 1 commit into
Open
[Cobalt] Add URL sanitization for URLs provided by the platform.#12470jshorta wants to merge 1 commit into
jshorta wants to merge 1 commit into
Conversation
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request enforces that the startup URL points strictly to YouTube TV in release builds, rerouting invalid URLs to a deep link and sanitizing the arguments. The review feedback correctly identifies a critical lifetime issue where 'initial_deep_link' could become a dangling pointer by referencing a temporary local string, and suggests using a reference to 'init_argv.back()' instead. It also recommends adding a defensive check to ensure 'args' is not empty before accessing 'args.back()'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use deep link resolution for URLs that don't start with the YTLR prefix.
Bug: 503024637