feat(cli): keep AWS deploy secrets off the runner - #937
Open
m-mohamed wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security boundary
This removes routine plaintext secret retrieval from the CLI runner. It is not a sandbox against the deployment principal: a principal allowed to register arbitrary task definitions and pass the runtime role can still deploy code that exfiltrates runtime secrets. The README and Terraform tests state that boundary explicitly.
Verification
An independent review verified that plan performs no ECS RunTask, service mutation, S3 write, DynamoDB lease, RDS snapshot, or ECR mutation; value validation remains fail-closed for up and live checks.