Skip to content

Accept secret-backed Codex credentials in deploy plans - #921

Open
m-mohamed wants to merge 1 commit into
yc-software:mainfrom
m-mohamed:codex/accept-secret-bound-codex-auth
Open

Accept secret-backed Codex credentials in deploy plans#921
m-mohamed wants to merge 1 commit into
yc-software:mainfrom
m-mohamed:codex/accept-secret-bound-codex-auth

Conversation

@m-mohamed

@m-mohamed m-mohamed commented Sep 3, 2026

Copy link
Copy Markdown

Summary

  • count a secretEnv binding as a configured runtime environment value for presence-based secret conditions
  • require OPENAI_API_KEY for the Codex harness only when no keychain credential is bound
  • keep non-Codex OpenAI model-provider deployments on the API-key requirement

This makes the CLI deployment contract match core runtime validation: production Codex may authenticate from an operator-managed keychain credential without a duplicate API-billed key.

Verification

  • red test reproduced the incorrect OPENAI_API_KEY requirement
  • focused regression test passes
  • npm run typecheck
  • npm run lint
  • node --test cli/test/secrets.test.ts (32/32)
  • root and CLI production dependency audits: 0 vulnerabilities

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant