Repository navigation
Patch pointer root - #8
Merged
Merged
Conversation
split_pointer took any pointer without a '/' for the root "", so add (and move/copy, which add) replaced the whole document with the value, and remove reported "cannot remove the root". Only "" is the root now; any other pointer missing its leading slash raises the crate's own InvalidPointer error as ArgumentError, the message at_pointer gives. Found by the patch fuzzer. The new seed pins the shape for CI.
The json 3 cleanup made generate_lines a must-succeed stage on the belief that lone surrogates were the only ungenerable parse output. An overflow float (1e999) parses to Infinity, which plain generate refuses: both weekly runs since failed on it, and 64 inputs of the local corpus already did. Like reformat_case, retry under allow_nan, which lifts exactly that refusal, and read the result back under it. The new seed fails on the previous prelude.
splice, add, and replace generate their values with default options, which refuse non-finite floats, while an overflow literal in the spec (1e999) parses to Infinity: native raised GeneratorError where the reference inserted Infinity. The reference now refuses such values at the same ops. test compares and move/copy splice raw document bytes, so a 1e999 already in the document still passes there; a seed pins each side of that line.
The Rails jobs re-resolve without the lockfile, and json was only ever held at 2.x by standard's rubocop. standard 1.57 (2026-10-05) moved to rubocop 1.91, which allows json 3, and stock ActiveSupport 7.1 and 8.0 pass quirks_mode to JSON.generate and JSON.parse, which json 3 rejects even without nosj. Pin json explicitly per line: 7.1 and 8.0 on json 2, 7.2 and 8.1 on json 3 (both verified working stock).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.