buildspec completed for CI/CD. - #5
Open
benjamistan wants to merge 1 commit into
Open
Conversation
Adding buildspec.yml for AWS CodePipeline
benjamistan
force-pushed
the
feat/buildspec
branch
from
February 16, 2021 11:33
da5c255 to
e18f195
Compare
v-stickykeys
left a comment
v-stickykeys
left a comment
Member
There was a problem hiding this comment.
LGTM! Just a few questions.
|
|
||
| env: | ||
| parameter-store: | ||
| AWS_ACCOUNT_ID: account_id |
Member
There was a problem hiding this comment.
How does this work? Is it coming from github secrets? If not that's an easy way to get this.
| - echo Build started on `date` | ||
| - echo Building the Docker image... | ||
| - docker build -t $REPOSITORY_URI:latest . | ||
| - docker tag $REPOSITORY_URI:latest $REPOSITORY_URI:$IMAGE_TAG |
Member
There was a problem hiding this comment.
Can we also include branch name as an additional tag?
| - docker push $REPOSITORY_URI:latest | ||
| - docker push $REPOSITORY_URI:$IMAGE_TAG | ||
| - echo Writing image definitions file... | ||
| - printf '[{"name":"godmode-ganache-cli","imageUri":"%s"}]' $REPOSITORY_URI:$IMAGE_TAG > imagedefinitions.json |
Member
There was a problem hiding this comment.
Why do we need to write this to a json file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple buildspec updates ECR (not Docker Hub) with any changes.
No artifact output.