Repository navigation
chore: fix bundle on Ruby 4.0 - #20
Merged
Merged
Conversation
- Update unicode-emoji 4.0.4 -> 4.3.0 and unicode-display_width 3.1.4 -> 3.3.0: unicode-emoji 4.0.4 requires Ruby < 4.0, so `bundle` failed to resolve on the pinned Ruby 4.0.4. - Lock Bundler 4.0.19 (ships with Ruby 4.0): Bundler 2.5.22 on RubyGems 4.0 prints "already initialized constant Gem::Platform" warnings, which leak into the CLI's stderr under `bundle exec` and fail the integration tests. Updated conservatively; json, prism and RuboCop 1.77.0 stay as locked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundlefails on the pinned Ruby 4.0.4 (.ruby-version):This updates
Gemfile.lockonly:unicode-emoji4.0.4 → 4.3.0 andunicode-display_width3.1.4 → 3.3.0 (both require Ruby >= 2.5). Updated withbundle lock --update … --conservative, sojson,prismand RuboCop 1.77.0 stay as locked.BUNDLED WITH2.5.22 → 4.0.19, the Bundler that ships with Ruby 4.0. On RubyGems 4.0, Bundler 2.5.22 printsalready initialized constant Gem::Platform::…warnings. Underbundle execthey leak into the CLI subprocesses' stderr and fail 7 integration tests that assert empty stderr.Impact
gem install rubocop -v 1.77.0./usr/bin/ruby2.6.10: 204 runs, 0 failures, 100% coverage).Verification (Ruby 4.0.4)
bundle installresolves and installs.bundle exec rake: 204 runs, 0 failures; RuboCop: 32 files, no offenses.