fix: maintaince workflow prep and fixes - #403
Conversation
wmcmahan
left a comment
There was a problem hiding this comment.
Advisory review by the pr-review workflow — the human merge decision stands either way.
VERDICT: APPROVE
The new PrWire setting reaches every place that writes or reads markers and mentions in production code. The orchestrator loop guards are tested and do what the changeset says.
This is a careful refactor. Legacy values stay readable, contextOf rejects unsafe namespaces and mentions, and the tests are exact and named for the behaviour they check.
What I checked in the tree:
- Marker and mention sites: every production
reviewMarker,stripMentions,markerKindOfandwithoutMarkerssite passesctx.prWire. That coverspost-review.ts,push-revision.ts(includingrevisionSummary'sstamp.wire),gather-pr.tsandgather-feedback.ts. - Leftovers from the move:
stripMentionsandWORKFLOW_MENTIONno longer exist inshared/repo.js. They are only imported frompr-wire.js, and no stale imports are left. - Workflow files: the hard-coded
<!-- cycgraph:pr-notice -->inpr-review.ymlandpr-revise.ymlis the known mirror that the JSDoc onPrWire.mentionandMaintenanceContext.prWirealready calls out. - Cost limits:
costLimitsreads the run's remaining budget each time it checks, so spend from earlier nodes counts. The check only runs when the loop would take another step, and a continuation step is blocked once a limit is reached. Tests are inagent-executor-loop.test.ts. - Final-answer check:
finalAnswerProblemtreats a check that throws as passing. Runner and registry setups both reach it throughexecutor-context-builder.ts:285. - Sanitizer:
sanitizers.ts:49now escapes the opening<of tag-shaped text to<instead of deleting the tag, so</data>and<system>still can't open or close a prompt boundary.
One point about the change as a whole, not blocking: CONTRIBUTING.md asks for "one concern per PR". This PR combines a refactor of the internal maintenance tooling's comment format with a minor release of cycgraph/orchestrator: in-loop budget checks, BudgetExceededError.unit, agent output stored without sanitizing, and finalAnswer checks. The title "maintaince workflow prep and fixes" doesn't describe the orchestrator part. Next time, put a published-package minor in its own PR so its changelog and review history stand alone.
Reviewed at 91a1a79 · with claude-opus-5-5 · workflow run
No description provided.