Skip to content

fix: maintaince workflow prep and fixes - #403

Merged
wmcmahan merged 1 commit into
mainfrom
chore/keel
Oct 1, 2026
Merged

wmcmahan merged 1 commit into
mainfrom
chore/keel

Conversation

@wmcmahan

@wmcmahan wmcmahan commented Oct 1, 2026

Copy link
Copy Markdown
Owner

No description provided.

@wmcmahan wmcmahan left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advisory review by the pr-review workflow — the human merge decision stands either way.

VERDICT: APPROVE
The new PrWire setting reaches every place that writes or reads markers and mentions in production code. The orchestrator loop guards are tested and do what the changeset says.

This is a careful refactor. Legacy values stay readable, contextOf rejects unsafe namespaces and mentions, and the tests are exact and named for the behaviour they check.

What I checked in the tree:

  • Marker and mention sites: every production reviewMarker, stripMentions, markerKindOf and withoutMarkers site passes ctx.prWire. That covers post-review.ts, push-revision.ts (including revisionSummary's stamp.wire), gather-pr.ts and gather-feedback.ts.
  • Leftovers from the move: stripMentions and WORKFLOW_MENTION no longer exist in shared/repo.js. They are only imported from pr-wire.js, and no stale imports are left.
  • Workflow files: the hard-coded <!-- cycgraph:pr-notice --> in pr-review.yml and pr-revise.yml is the known mirror that the JSDoc on PrWire.mention and MaintenanceContext.prWire already calls out.
  • Cost limits: costLimits reads the run's remaining budget each time it checks, so spend from earlier nodes counts. The check only runs when the loop would take another step, and a continuation step is blocked once a limit is reached. Tests are in agent-executor-loop.test.ts.
  • Final-answer check: finalAnswerProblem treats a check that throws as passing. Runner and registry setups both reach it through executor-context-builder.ts:285.
  • Sanitizer: sanitizers.ts:49 now escapes the opening < of tag-shaped text to &lt; instead of deleting the tag, so </data> and <system> still can't open or close a prompt boundary.

One point about the change as a whole, not blocking: CONTRIBUTING.md asks for "one concern per PR". This PR combines a refactor of the internal maintenance tooling's comment format with a minor release of cycgraph/orchestrator: in-loop budget checks, BudgetExceededError.unit, agent output stored without sanitizing, and finalAnswer checks. The title "maintaince workflow prep and fixes" doesn't describe the orchestrator part. Next time, put a published-package minor in its own PR so its changelog and review history stand alone.

Reviewed at 91a1a79 · with claude-opus-5-5 · workflow run

@wmcmahan
wmcmahan merged commit 6902280 into main Oct 1, 2026
18 checks passed
@wmcmahan
wmcmahan deleted the chore/keel branch October 1, 2026 17:30

This branch was successfully deployed

1 active deployment
Preview — 4f498cf2 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant