You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rather, what's missing there is a cd build, then the recipe works. The build directory that is there in the package itself is from wheel and should not be used when using the cmake interface (build files will be different). The idea here is to create a directory (called build or whatever) outside the main package.
@wlav Got it. After cd build when running cmake ../CPyCppyy shows the error: /path/CPyCppyy source not found. The command should be cmake ../../CPyCppyy which runs successfully.
No, I still don't quite understand. Structure that I envision is like this:
<workdir>
\- CPyCppyy
\- build
so the CMakeLists.txt file is found in ../CPyCppyy when you're in build.
It all doesn't matter a whole lot, just that since pip creates and uses a build directory in CPyCppyy, all one should care about is that the two directories are disjoint.
Note that the only reason for using cmake to build is that running make (or whatever build system you prefer) is a whole lot faster than using pip in development mode, so it saves time. cmake isn't otherwise used in the distribution/installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While building the project, I noticed the following points that needs to be addressed in the documentation to avoid any confusions.
We do not need to create
$ mkdir builddirectory again because it already gets created during the previous steps.Local module
libcppyy.soexists inrootdirectory of CPyCppyy not inbuilddirectory.