(suggestion) make map saves per-map

[Fennecai]

It doesnt make much sense, at least to me, that a map save will apply to maps that arent the same map. I cant personally think of any use case where that would be useful other than maybe carrying a map save over to a day/night version of an otherwise identical map. In most cases, when i save a map, i actually dont want it to load the same file on other maps because props will be in weird mis-matched positions and such.

my suggestion is to modify the map save functionality in a way where it'll save and load per-map, based on the current loaded map. This should be relatively straight-forward to do, since i actually modified my copy of advdupe2 to do exactly this.

all i did was point all the relevant file.write calls to a subfolder of advdupe2_maps based on game.GetMap(), instead of only writing directly into advdupe2_maps.. so for example, if i'm playing on gm_mobenix, instead of saving autoload.txt to data/advdupe2_maps/autoload.txt, it now saves to data/advdupe2_maps/gm_mobenix/autoload.txt.

I also made the relevant changes to all the places where it loads the file.

[thegrb93]

CreateConVar("AdvDupe2_LoadMap", "0", {FCVAR_ARCHIVE}, "A non-zero value will load a dupe at game start based on the map from file \"advdupe2_maps/<map name>.txt\". A value of 2 will unfreeze everything after pasting.")

local function PasteMap()
	local maptype = GetConVarNumber("AdvDupe2_LoadMap")
	if maptype==0 then return end

	local filename = "advdupe2_maps/"..game.GetMap()..".txt"
	if(not file.Exists(filename, "DATA"))then
		print("[AdvDupe2Notify]\tFile does not exist for a map save.")
		return
	end
	
	local success,dupe,info,moreinfo = AdvDupe2.Decode(file.Read(filename)) 
	if not success then
		print("[AdvDupe2Notify]\tCould not open map save "..dupe)
		return
	end	
	
	local Tab = {Entities=dupe["Entities"], Constraints=dupe["Constraints"], HeadEnt=dupe["HeadEnt"]}
	local Entities = AdvDupe2.duplicator.Paste(nil, table.Copy(Tab.Entities), Tab.Constraints, nil, nil, Tab.HeadEnt.Pos, true)
	
	local PhysObj
	for k,v in pairs(Entities) do
		if(IsValid(v))then
			for i=0, #Tab.Entities[k].PhysicsObjects do
				PhysObj = v:GetPhysicsObjectNum( i )
				if IsValid(PhysObj) then
					PhysObj:EnableMotion(maptype==2 or Tab.Entities[k].PhysicsObjects[i].Frozen)
				end
			end
			if v.CPPISetOwner then v:CPPISetOwner(game.GetWorld()) end
		end
	end

	print("[AdvDupe2Notify]\tMap save pasted.")
end

[Fennecai]

well, tbh the version i made also allows multiple different saves but they are still loaded per-map, if that makes sense? so i could have a save called "obstace course 1" and have it be different on different maps. heres my code. i didnt post it originally because i assumed it was incompatible with updates that may have happened between now and when i originally modified it, but the code you posted seems like its pretty similar anyway lol.

local function PasteMap()
	if(GetConVarString("AdvDupe2_LoadMap")=="0")then return end
	local filename = GetConVarString("AdvDupe2_MapFileName")
	
	if(not filename or filename == "")then
		print("[AdvDupe2Notify]\tInvalid file name to loap map save.")
		return
	end
	
	if(not file.Exists("advdupe2_maps/" .. game.GetMap() .. "/" ..filename..".txt", "DATA"))then
		print("[AdvDupe2Notify]\tFile does not exist for a map save.")
		return
	end
	
	local map = file.Read("advdupe2_maps/" .. game.GetMap() .. "/" ..filename..".txt")
	local success,dupe,info,moreinfo = AdvDupe2.Decode(map) 
	if not success then
		print("[AdvDupe2Notify]\tCould not open map save "..dupe)
		return
	end	
	
	local Tab = {Entities=dupe["Entities"], Constraints=dupe["Constraints"], HeadEnt=dupe["HeadEnt"]}
	local Entities = AdvDupe2.duplicator.Paste(nil, table.Copy(Tab.Entities), Tab.Constraints, nil, nil, Tab.HeadEnt.Pos, true)
	local maptype = GetConVarString("AdvDupe2_LoadMap")
	
	if(maptype=="1")then
		local PhysObj
		for k,v in pairs(Entities) do
			if(IsValid(v))then
				for i=0, #Tab.Entities[k].PhysicsObjects do
					if(Tab.Entities[k].PhysicsObjects[i].Frozen)then
						PhysObj = v:GetPhysicsObjectNum( i )
						if IsValid(PhysObj) then
							PhysObj:EnableMotion(true)
						end
					end
				end
				if v.CPPISetOwner then v:CPPISetOwner(game.GetWorld()) end
			end
		end
	elseif(maptype=="2")then
		local PhysObj
		for k,v in pairs(Entities) do
			if(IsValid(v))then
				for i=0, #Tab.Entities[k].PhysicsObjects do
					PhysObj = v:GetPhysicsObjectNum( i )
					if IsValid(PhysObj) then
						PhysObj:EnableMotion(true)
					end
				end
				if v.CPPISetOwner then v:CPPISetOwner(game.GetWorld()) end
			end
		end
	end
	
	print("[AdvDupe2Notify]\tMap save pasted.")
end