Skip to content

feat: load-more pagination for conversation drive search view(WPB-25540) - #21446

Merged
arjita-mitra merged 2 commits into
devfrom
feat/implement-pagination-drive-conversation
Jun 8, 2026
Merged

feat: load-more pagination for conversation drive search view(WPB-25540)#21446
arjita-mitra merged 2 commits into
devfrom
feat/implement-pagination-drive-conversation

Conversation

@arjita-mitra

@arjita-mitra arjita-mitra commented Jun 5, 2026

Copy link
Copy Markdown
Contributor
TaskWPB-25540 Pagination for search results

Conversation Drive now switches pagination model based on the search view state

  • Browse mode (search view closed): Page number and rows per page based pagination unchanged

  • Search mode (search view open, regardless of typed query or filters):

    Load More button with 30 initial rows + 20 per click, matching the global All Files view's progression.

Conversation Drive now switches pagination model based on the search view state

- Browse mode (search view closed): Page number and rows per page based pagination unchanged

- Search mode (search view open, regardless of typed query or filters):

  Load More button with 30 initial rows + 20 per click, matching the
  global All Files view's progression.
@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.66667% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.69%. Comparing base (c4f55a6) to head (f15bcba).
⚠️ Report is 117 commits behind head on dev.

Files with missing lines Patch % Lines
...seConversationSearch/useConversationSearchFiles.ts 0.00% 31 Missing ⚠️
...nversation/ConversationCells/ConversationCells.tsx 0.00% 27 Missing ⚠️
...rsationCells/common/useCellsStore/useCellsStore.ts 0.00% 6 Missing ⚠️
...onCells/useGetAllCellsNodes/useGetAllCellsNodes.ts 0.00% 4 Missing ⚠️
...p/src/script/repositories/cells/cellsRepository.ts 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (16.66%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #21446      +/-   ##
==========================================
- Coverage   45.73%   45.69%   -0.04%     
==========================================
  Files        1703     1704       +1     
  Lines       43925    43989      +64     
  Branches     9134     9160      +26     
==========================================
+ Hits        20088    20102      +14     
- Misses      21576    21626      +50     
  Partials     2261     2261              
Flag Coverage Δ
app_webapp 43.86% <16.66%> (-0.04%) ⬇️
lib_api_client 51.86% <ø> (ø)
lib_core 59.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tion/ConversationCells/ConversationCells.styles.ts 100.00% <100.00%> (ø)
...ls/common/loadMorePagination/loadMorePagination.ts 100.00% <100.00%> (ø)
...p/src/script/repositories/cells/cellsRepository.ts 8.06% <0.00%> (-0.27%) ⬇️
...onCells/useGetAllCellsNodes/useGetAllCellsNodes.ts 2.50% <0.00%> (-0.21%) ⬇️
...rsationCells/common/useCellsStore/useCellsStore.ts 8.33% <0.00%> (-1.67%) ⬇️
...nversation/ConversationCells/ConversationCells.tsx 3.12% <0.00%> (-0.96%) ⬇️
...seConversationSearch/useConversationSearchFiles.ts 2.65% <0.00%> (-0.80%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 15
  • Failed: 0
  • Skipped: 0
  • 🔁 Flaky: 0
  • 📊 Total: 15
  • Total Runtime: 136.1s (~ 2 min 16 sec)

@arjita-mitra arjita-mitra changed the title feat: load-more pagination for conversation drive search view feat: load-more pagination for conversation drive search view(WPB-25540) Jun 5, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

@arjita-mitra
arjita-mitra added this pull request to the merge queue Jun 8, 2026
Merged via the queue into dev with commit 5c67094 Jun 8, 2026
36 checks passed
@arjita-mitra
arjita-mitra deleted the feat/implement-pagination-drive-conversation branch June 8, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants