Skip to content

feat: update recurrence option names [WPB-27425] - #5138

Open
saleniuk wants to merge 1 commit into
developfrom
feat/update-repeating-interval-names
Open

feat: update recurrence option names [WPB-27425]#5138
saleniuk wants to merge 1 commit into
developfrom
feat/update-repeating-interval-names

Conversation

@saleniuk

@saleniuk saleniuk commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-27425


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Update names for recurrence options. Usual options, so up to 6 days (anything over that is a week) and up to 4 weeks (anything over that is a month) are written out in full, for example: “Every four weeks”, but just in case there is a fallback to the standard plural string.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

How to Test

Open dev-debug app, go to "Meetings", click "New", "Schedule a meeting" and check repeat options.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk
saleniuk marked this pull request as ready for review August 6, 2026 11:32
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.50%. Comparing base (4227a16) to head (dd27364).

Files with missing lines Patch % Lines
...wire/android/feature/meetings/model/MeetingItem.kt 38.46% 7 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (38.46%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5138      +/-   ##
===========================================
- Coverage    50.52%   50.50%   -0.02%     
===========================================
  Files          671      671              
  Lines        24604    24614      +10     
  Branches      3832     3834       +2     
===========================================
+ Hits         12430    12432       +2     
- Misses       11029    11036       +7     
- Partials      1145     1146       +1     
Files with missing lines Coverage Δ
...wire/android/feature/meetings/model/MeetingItem.kt 75.00% <38.46%> (-16.18%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4227a16...dd27364. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 225 tests  ±0   2 225 ✅ ±0   2m 18s ⏱️ +31s
  241 suites ±0       0 💤 ±0 
  241 files   ±0       0 ❌ ±0 

Results for commit dd27364. ± Comparison against base commit 4227a16.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants