Skip to content

feat: use meetings feature flag [WPB-25684] - #5134

Open
saleniuk wants to merge 7 commits into
developfrom
feat/meetings-feature-flag
Open

feat: use meetings feature flag [WPB-25684]#5134
saleniuk wants to merge 7 commits into
developfrom
feat/meetings-feature-flag

Conversation

@saleniuk

@saleniuk saleniuk commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25684


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Replace build-time flag for meetings with a feature flag from kalium.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Log in using team account that has meetings feature flag disabled and enable that flag after logging in.

Attachments (Optional)

enabling.meetings.feature.flag.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk
saleniuk marked this pull request as ready for review August 5, 2026 14:19
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 227 tests  +2   2 227 ✅ +2   1m 51s ⏱️ +4s
  241 suites ±0       0 💤 ±0 
  241 files   ±0       0 ❌ ±0 

Results for commit 3442df5. ± Comparison against base commit 4227a16.

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size Bot added size/S and removed size/XS labels Aug 5, 2026
…ure-flag

# Conflicts:
#	features/meetings/src/main/java/com/wire/android/feature/meetings/ui/create/NewMeetingViewModel.kt
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.52%. Comparing base (4227a16) to head (3442df5).

Files with missing lines Patch % Lines
...n/com/wire/android/ui/home/HomeViewModelFactory.kt 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5134   +/-   ##
========================================
  Coverage    50.52%   50.52%           
========================================
  Files          671      671           
  Lines        24604    24608    +4     
  Branches      3832     3832           
========================================
+ Hits         12430    12433    +3     
- Misses       11029    11031    +2     
+ Partials      1145     1144    -1     
Files with missing lines Coverage Δ
...wire/android/ui/home/drawer/HomeDrawerViewModel.kt 100.00% <100.00%> (+2.32%) ⬆️
...n/com/wire/android/ui/home/HomeViewModelFactory.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4227a16...3442df5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants