Repository navigation
ci: deploy talks to GitHub Pages - #17
Merged
Merged
Conversation
Builds each deployable talk (build_to_burn for now) for web with --wasm on push to main and hosts it at its own Pages URL (https://whynotmake-it.github.io/talks/<app>/), like the rivership example deploy but with one Flutter app per talk instead of a meta-app. The pub workspace is trimmed to deployable apps during CI so outdated apps and their deps (e.g. physical_ui's private git dependency) can't break resolution. Add more talks via the TALKS env var. PR builds run the wasm build as a check without deploying.
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
paper_liquid_metal_logo comes from the private whynotmake-it/glibber repo via SSH, which broke every CI job that resolves the pub workspace (melos bootstrap, root flutter pub get). Removes the dep, its only consumer (LiquidMetalLogo / SpecialEffects.liquidMetal in the surfaces slide), and the now-unused scribble dependency.
Stale vs current plugin versions (video_player plugin class rename, dropped path_provider) — this is what 'Check Code Generation' asserts. The drift was previously masked by the glibber bootstrap failure.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
.github/workflows/deploy.yamlthat builds the talks for web with--wasmand deploys them to GitHub Pages on push tomain, so each talk is shareable via its own link:https://whynotmake-it.github.io/talks/build_to_burn/— one Flutter app per talk, no meta-app. The Pages root gets a small generated index linking to each talk..github/workflows/deploy.yaml), extended with aTALKSenv var + build loop — adding a talk later is a one-word change.workspace:to the deployable apps, so outdated apps and their deps can't break or slow down resolution.refs/heads/main.Also fixes CI, which was failing on
mainfor two masked reasons:paper_liquid_metal_logo(privatewhynotmake-it/glibberdep via SSH) fromapps/physical_ui— it brokemelos bootstrap/flutter pub geton every runner. Its only consumer (LiquidMetalLogo/SpecialEffects.liquidMetalin the surfaces slide) and the now-unusedscribbledep are removed too.Check Code Generationfailure previously hidden behind the bootstrap failure.Verified locally on Flutter 3.47.6 (stable, per
.fvmrc): trimmedflutter pub getresolves,flutter build web --release --wasm --base-href /talks/build_to_burn/builds (~66s), and the full workspace resolves without the private dep.Setup needed: repo Settings → Pages → Source must be "GitHub Actions". No secrets required.
Still red:
Build Checkfails inmelos analyze --fatal-infoson ~45+ pre-existing info-level lints inphysical_ui/gaussian_splatting(mostly motor 2.0 deprecations — the workspace-widemotoroverride forces 2.0 APIs onto apps written against 1.x). Lint debt in the outdated apps, separate from this PR.Checklist
CI/cleanup change; no public APIs.
Link to Devin session: https://app.devin.ai/sessions/140ba1ea993f43a99edd703aefa73342
Open in Devin Desktop: https://app.devin.ai/desktop/session/140ba1ea993f43a99edd703aefa73342?variant=devin
Requested by: @timcreatedit