Skip to content

feat: improve command display in options page - #35

Merged
whatasoda merged 3 commits into
mainfrom
feat/options-command-display-order
Dec 29, 2025
Merged

whatasoda merged 3 commits into
mainfrom
feat/options-command-display-order

Conversation

@whatasoda

Copy link
Copy Markdown
Owner

Summary

  • Fix command display order: _execute_action → open-popup → move-tab-left → move-tab-right
  • Use i18n (t()) for command descriptions instead of Chrome API values
  • Reorganize layout: Mode selection now appears to the right of command name

Test plan

  • Open options page and verify command order is correct
  • Verify _execute_action description displays properly
  • Verify Mode selection appears to the right of command name for popup commands
  • Verify "Select on re-press" appears below the key settings

🤖 Generated with Claude Code

whatasoda and others added 3 commits December 29, 2025 21:06
Add explicit ordering for commands: _execute_action, open-popup,
move-tab-left, move-tab-right. Previously relied on Chrome API
return order which could be inconsistent.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use t() function with message keys for command descriptions instead
of relying on Chrome API's description field. This ensures consistent
localized descriptions, especially for _execute_action which may not
return a description from the Chrome API.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move Mode selection to the right of command name in the header row.
Select on re-press checkbox now appears below the key settings.
Removed unused settingRow style.

Layout change:
Before: [Name] [Key] / [Select on re-press] / [Mode]
After:  [Name] [Mode] [Key] / [Select on re-press]

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@whatasoda
whatasoda merged commit 1354217 into main Dec 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant