Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #391
Changes proposed in this PR
On Apple platforms,
FileManager.unzipItemcan retain autoreleased Foundation objects until the caller's autorelease pool drains. When extracting many small entries, peak memory grows with the number of entries.Extract each entry inside its own
autoreleasepoolwhen Objective-C is available, following the workaround described in #391. Other platforms call the same extraction helper directly. The helper retains the existing containment checks, symlink restrictions, progress handling, and CRC32 validation; the checksum check is inlined into it.Tests performed
-Xswiftc -enable-testing --enable-code-coverage.swiftlint lint --strict --quiet Sources Testspassed.unzipIteminside one outer autorelease pool, without aProgress, in a fresh process per run./usr/bin/time -lreported:The 10,000-entry case used about 59% less peak RSS. Every extracted file was compared byte-for-byte with its ZIP payload. These are macOS measurements; an iOS device OOM scenario and non-Apple builds have not been tested locally.
Reproduce the memory measurement
Generate each input archive with Python:
Use this
main.swiftin a SwiftPM executable that depends on the checkout being measured:Build with
swift build -c release, then use a fresh destination directory for each execution:Compare the
maximum resident set sizevalues before and after the change.Replaces #405 after renaming the source branch; the commits are unchanged.