Repository navigation
fix(wework): protect document links and native credentials - #4479
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthrough
Merge Risk:
|
# Conflicts: # wework/electron/src/host/secret-protection.test.ts
…ites Integrate main upgrade policy changes with the suite25 credential acceptance contract. Resolve private model references inside the native host before existing local or configured cloud runtime dispatch. Fix native authorization, modal targeting, foreground input and reference-navigation defects established by current desktop CI logs.
Preserve the upstream personal-work navigation and DOCX preview retry entry. Keep native security fixes, suite25 acceptance, and the existing desktop image unchanged.
Integrate main baa2b17 after the confirmed navigation conflict, preserving new knowledge-event coverage and the DOCX Retry entry. Resolve GTK EWMH modal discovery and require native idleness before cloud fault injection. Isolate ordinary macOS test credential identities and retain release identities. Capture the unresolved browser transport cause without request URLs.
Integrate main 8d19c8d while preserving native credential isolation, DOCX sanitization, explicit plugin approval and suite25 upgrade evidence. Resolve saved MiniMax discovery inside the native host and reuse the shared model probe with redirects denied. Validate the latest published Beta source against the next nonpublishing candidate.
Keep the original assertion Promise bound to its Inspector object group until its real result is returned, with immediate rejection observation and the existing shared evaluation deadline. Release bindings on every exit without masking the original failure. Add real V8 garbage-collection, rejection, ownership and disconnect regression coverage to the existing native contract suite. Select the latest published Beta.2 as the source floor for the next nonpublishing Beta candidate.
Classify verified history pagination, saved invocation and Goal eligibility reads so their original responses finish before changing authentication. Preserve native continuation ownership, mutation and unknown-request guards, and the existing admission deadline. Record queued-turn admission ownership and cleanup boundaries to diagnose the unresolved async-answer queue failure without changing scheduling semantics. Cover cleanup order and queueIfBusy combinations through the existing handler unit suite. Keep Dockerfiles and original E2E assertions unchanged.
DOCX 危险链接可能在第三方预览中执行,通用密钥接口及前端模型探测扩大了凭据暴露面。本变更在渲染前净化 DOCX 关系链接,移除 HTTP/SDK 通用密钥接口,将保存凭据、模型发现及已保存模型探测收敛到 Electron 原生服务。
首次原子复制旧模型配置、模型密钥及云设备凭据到
protected-credentials,秘密使用系统保护的 v3 存储;之后只读写新版存储,清空或退出保留空标记。旧文件保留供原版回滚,新旧版本后续写入独立,历史旧文件暴露风险仍存在。手动选择旧目录文件、目录别名及旧绑定时也先复制到新版保护目录;普通外部配置仍可编辑。保存连接改址须重新输入密钥,原生接口不返回密钥或远端错误正文。Core 插件支持 npm、Git 和绝对本地来源。安装、更新及开发启动前,原生窗口显示字面来源与执行风险,默认取消;HTTP 入口遵循同一授权,取消先于事务、停止现有开发会话及创建进程。已删除自动放行受阻安装脚本的重试。DOCX 危险外部关系保持惰性,HTTPS 对照保留;读取或安全处理失败时可显式重试。
当前 HEAD:
46056966d2d00ed531613beb788e52f879782166;已集成 main28bc61061eecaf8ae7f3eab2aca019872a6cfe17。功能完成后已整体审查,最终树为aea547c275f9c89c60a0a5fefdf13184c8eba7de,工作区干净。正常提交钩子通过;按用户要求未手动运行本机测试、类型、lint、编译或 E2E 套件,以下执行结果均来自当前 HEAD 的 GitHub CI。模型目录复用现有缓存抽象,本机和云端独立发布;普通对话保留仍有效的模型和选项,提交本机设置会使旧读取失效,迟到响应不能覆盖新状态。保留原有身份合并、凭据和执行权限边界。测试夹具复用现有隔离运行时与 UI 模型选择器,明确场景协议前提;插件策略准备采用上游设备 ACK 与现有写锁,不依赖偶然调度顺序。原始断言、期限、授权和取消覆盖保留。
保留上游停止后迁移、会话/Goal/历史连续性、归档所有权及同步消息接纳规则,源内容通过已授权工具读取。Dockerfile 相对已集成 main 完全不变,复用现有测试镜像和共享产物,没有组织镜像写入。
当前 HEAD 的验证结果:
0.6.10-beta.5,channel=beta、publish_release=false、build_only=false、verification_checkpoint=all。未指定版本覆盖,未发布版本或推广目录。0.6.10-beta.2(06f2cbee8b4371072fbd8477fcd2d6985431f710)和当时最新已发布0.6.10-beta.4(66e8ab3455cbccebbf7f6c72dadfda87d234ae37),目标为 Beta.5。suite25 的 4 组独立真实包升级/回滚/再升级均通过:macOS arm64 的 Beta.2、Beta.4,Windows x64 的 Beta.2、Beta.4。已回读全部原始报告并核对双端包哈希、sourceSha、suite25、运行号及成功 CI。实际目标升级包 SHA256:
d96bed313c0b7fc58cf11dcd16572f8cdf068028d9190e6002150ad53c4c95a0a6059500878262a4fae57553afa82a634cce8d0ed890ac6bd7f06fc696db2201844cd62324225ca9a299b9a35844a6d9ddf6c24762f1a9f66c286c9d143a2d54保留事项:升级验证执行约 14 分 18 秒,超出现有 10 分钟性能目标,原有警告保留;未延长硬期限或放宽断言,CI 最终成功。历史 Core1 排队失败的旧日志未能证实根因,当前 HEAD 原场景已通过,不据此宣称旧根因已解决。四条旧来源失败与 evidence=null 保留,不生成新升级边;旧文件历史凭据暴露风险仍在既定验收边界内。
安全交接 Issue:WEWORK2D8526-144;跟进任务:WEWORK2D8526-168。当前 HEAD 的必需 CI 与完整真实包证据均已通过,交 qindi 复审;收到明确人工同意并满足仓库保护后再合并。
Summary by CodeRabbit