types(runtime-dom): allow null native attribute values (fix #8600) - #15240
Open
KasraK2K wants to merge 2 commits into
Open
types(runtime-dom): allow null native attribute values (fix #8600)#15240KasraK2K wants to merge 2 commits into
KasraK2K wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe runtime DOM JSX declarations now allow ChangesNullable JSX Native Props
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
KasraK2K
marked this pull request as ready for review
August 8, 2026 16:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullfor native HTML, SVG, and ARIA binding valuesNativeElementsboundary so component prop contracts remain unchangedRoot cause
Vue removes or resets native DOM attributes and properties when their runtime value is
null, butNativeElementsexposed the underlying attribute types without includingnull. Template tooling and TSX therefore rejected values that the runtime supports.Validation
TS2322errors onmainforid,aria-label,disabled, andviewBoxpnpm run build-dtspnpm run test-dts-onlypnpm run checkCloses #8600.
Summary by CodeRabbit
nullis accepted for native element properties, including ARIA attributes, input boolean attributes, and SVG attributes.